Fix Weapon and Shield Sprite

[MrKeiKun]

Pull Request Prelude

• I have followed proper Hercules code styling.
• I have read and understood the contribution guidelines before making this PR.
• I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

Issues addressed:
#3285
#2967

[skyleo]

What client versions did you test this for?

I think this may be affecting the LOOK_SHOES case in clif_changelook as well if the same holds.

[skyleo]

Okay, I believe this may be bad for older clients. So preferably you should test this for at least 3 different jobs.
And this should be guarded by a PACKETVER ifdef. So you'll have to at least check one client per year for the range you'll be covering. I believe for older clients this is guaranteed to break stuff o-o

[MrKeiKun]

What client versions did you test this for?

I think this may be affecting the LOOK_SHOES case in clif_changelook as well if the same holds.

i have no way of testing right now. i only trace codes.

Okay, I believe this may be bad for older clients. So preferably you should test this for at least 3 different jobs. And this should be guarded by a PACKETVER ifdef. So you'll have to at least check one client per year for the range you'll be covering. I believe for older clients this is guaranteed to break stuff o-o

@kyeme hopefully can test it.

[kyeme]

After applying the code, the issue became worse. The shield is no longer visible both to other players and from my own point of view.

I’m using the 2016-01-06 client, and when I tried it on another client, it still didn’t work.

[MrKeiKun]

After applying the code, the issue became worse. The shield is no longer visible both to other players and from my own point of view.

I’m using the 2016-01-06 client, and when I tried it on another client, it still didn’t work.

i'll try to dig more if server really handles this correct, but if non found in server, possible client issue? @4144 might be key for this one

[MrKeiKun]

not sure if my latest commit fixes it @kyeme . hopefully you can try again :)

[kyeme]

@MrKeiKun Still not working

[MrKeiKun]

I'll dig more, seems to be a packet thing

[MrKeiKun]

@kyeme i adjusted the packet seems like older clients uses smaller size for weapon and shield i cannot pinpoint the dates i just used the modern condition dates as example. hopefully this works 😄

[kyeme]

@MrKeiKun
I applied the fix and it resolved the shield issue — now other players can see the shield without needing to re-equip.

However, the shield for Monk/Champion is still not visible. I tested this also on iRO official and confirmed that no shield is visible on Monk there either.

Could this be related to the client exe version being used?

[MrKeiKun]

@MrKeiKun I applied the fix and it resolved the shield issue — now other players can see the shield without needing to re-equip.

However, the shield for Monk/Champion is still not visible. I tested this also on iRO official and confirmed that no shield is visible on Monk there either.

Could this be related to the client exe version being used?

I need help about this @4144 @MishimaHaruna or @skyleo :D

[MrKeiKun]

@kyeme try again.

[kyeme]

I just want to add the other jobs where the shield sprite is not visible, aside from the Monk class:
• Sura
• Gunslinger
• Ninja
• Taekwon
• Soul Linker
• Star Gladiator
• Rebellion
• Kagerou
• Oboro

[kyeme]

@kyeme try again.

Thanks! Error fixed.

[MrKeiKun]

I just want to add the other jobs where the shield sprite is not visible, aside from the Monk class: • Sura • Gunslinger • Ninja • Taekwon • Soul Linker • Star Gladiator • Rebellion • Kagerou • Oboro

do this jobs really shows shield?