Migrating build system to cmake#3413

Open

hemagx wants to merge 40 commits into

hemagx commented May 23, 2026

Contributor

Pull Request Prelude

I have followed proper Hercules code styling.
I have read and understood the contribution guidelines before making this PR.
I am aware that this PR may be closed if the above-mentioned criteria are not fulfilled.

Changes Proposed

This Pull request changes our compilation generation tool to cmake so unify all platforms under a single umberalla, we also added conan as our dependency manager to get rid of as much of 3rdparty as possible and also the DLLs deployed for windows.

Issues addressed:

github-advanced-security AI commented May 23, 2026

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

hemagx added this to the Release v2026.05 milestone

hemagx requested review from MishimaHaruna and guilherme-gm

May 23, 2026 17:56

hemagx force-pushed the cmake branch from dc0bc59 to 150dc89 Compare

May 23, 2026 18:14

hemagx changed the base branch from stable to master

May 23, 2026 18:17

MishimaHaruna requested changes

View reviewed changes

MishimaHaruna left a comment

Member

Initial review - will continue later (I'm going commit by commit, so some comments might be outdated, feel free to close them)

CMakeLists.txt Outdated

CMakeLists.txt Outdated

cmake_modules/LanguageFeatureHelper.cmake Outdated

cmake_modules/LanguageFeatureHelper.cmake Outdated

cmake_modules/CompilerFlagHelpers.cmake Outdated

CMakeLists.txt Outdated

CMakeLists.txt Outdated

CMakeLists.txt Outdated

CMakeLists.txt Outdated

CMakeLists.txt Outdated

hemagx force-pushed the cmake branch from ca71e52 to 2763653 Compare

May 23, 2026 20:31

MishimaHaruna requested changes

View reviewed changes

src/common/CMakeLists.txt Outdated

CMakeLists.txt Outdated

MishimaHaruna requested changes

View reviewed changes

src/char/CMakeLists.txt Outdated

src/login/CMakeLists.txt Outdated

src/map/CMakeLists.txt Outdated

MishimaHaruna requested changes

View reviewed changes

CMakeLists.txt Outdated

MishimaHaruna force-pushed the cmake branch from 2763653 to b29bed0 Compare

May 23, 2026 22:22

hemagx force-pushed the cmake branch from b29bed0 to 0d3d3b5 Compare

May 23, 2026 22:40

MishimaHaruna force-pushed the cmake branch from 0d3d3b5 to 6a79301 Compare

May 23, 2026 23:01

MishimaHaruna requested changes

View reviewed changes

cmake_modules/GeneralHelpers.cmake Outdated

cmake_modules/GeneralHelpers.cmake Outdated

src/plugins/HPMHooking/CMakeLists.txt Outdated

src/plugins/sample.c

src/plugins/sample/sample.c Outdated

src/plugins/sample/sample.h Outdated

MishimaHaruna requested changes

View reviewed changes

tools/HPMHookGen/CMakeLists.txt

MishimaHaruna requested changes

View reviewed changes

3rdparty/libconfig/CMakeLists.txt Outdated

MishimaHaruna force-pushed the cmake branch 7 times, most recently from ff174a0 to 3742918 Compare

May 25, 2026 00:15

MishimaHaruna requested changes

View reviewed changes

src/common/core.c Outdated

3rdparty/libconfig/libconfig.h

src/common/sysinfo.c

               #include <stdlib.h> // atoi
               #ifdef WIN32
               #	include <windows.h>
+              #	include <winternl.h>

MishimaHaruna May 24, 2026

Member

What's this header providing here? It might be worth adding a comment to it since it's a quite unusual (and not very recommended) header to include

hemagx Jun 14, 2026

Contributor Author

This is for the NTSTATUS macro used later in code, idk why it didn't require it before, but since move to cmake it no longer saw it until this header is used :x

CMakeLists.txt Outdated

src/common/atomic.h

src/common/atomic.h

MishimaHaruna requested changes

View reviewed changes

tools/ci/travis.sh Outdated

tools/ci/travis.sh Outdated

.gitignore Outdated

CMakeLists.txt

    
            @@ -0,0 +1,570 @@
          
              # This file is part of Hercules.

MishimaHaruna May 25, 2026

Member

This script requires that the user passes some arguments (in particular the conan ones), that might be hard to remember. They should be documented in the project readme, and perhaps it would be nice to provide a convenience script (.sh and .bat/.ps1) with reasonable defaults

CMakeLists.txt Outdated

CMakeLists.txt Outdated

CMakeLists.txt Outdated

CMakeLists.txt

CMakeLists.txt

hemagx force-pushed the cmake branch from 3742918 to a751cf5 Compare

June 14, 2026 01:24

hemagx added 3 commits

June 14, 2026 05:19


          Implement a base cmake file that produces the same compile flags as a…

6067cb2

…n empty `./configure` run

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Addition of cmake files for 3rdparty dependencies we will keep buildi…

…ng on our own

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of pcre, zlib, cjson, libbacktrace and mariadb connector from…

72c1b14

… 3rdparty source folder

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>

hemagx added 28 commits

June 14, 2026 05:30


          Fix config headers was not being correctly added to server targets

dfb9c19

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Implement tests building and integeration with ctest

855a30b

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change plugins now to reside in their own directory and have their ow…

a16132d

…n CMakeFileLists.txt file

This would allow for more complex multi-file plugins and better customized build rules per plugin.
Due to this change any plugin that includes HPMHooks using path `plugins/HPMHooking.h` will now have to include it as `plugins/HPMHooking/HPMHooking.h`

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Implement doxygen docs generation target

995f06f

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Implement HPM hooks generation target

47199ee

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of the old makefile and autoconf build system

eba87bb

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Implement the ability for plugins to pass custom compiler flags

8c51d56

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Fix compile errors/warnings with plugin test_equippos

3e0f271

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Add sql custom target to emulate make file build behavior

afc1229

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Add -Wno-null-dereference to libconfig build as the lexer generated f…

ed91363

…ile tends to have possible false positives

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change file globs to have the flag CONFIGURE_DEPENDS

6e9d770

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Disable TLS verification in mariadb options

30c6532

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Move of tests under a cmake option ENABLE_TESTING so it's not compile…

92d04e1

…d unnecessirly

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Add a default installation target into source_dir/bin

b9bb1cb

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change hercules plugins install path to herc-plugins so it doesn't co…

c6ca7b8

…nflict with windows setup and corrected the RPATH for plugins to reflect directory structure

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Remove libgif from 3rdparty and move to conan package

42136f8

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Move nullpo_backtrace_get_executable_path to be a core function and d…

aacda0f

…oesn't depend on libbacktrace now the core will save current executable path to core->executable_path

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change hercules plugin directory to be relative to executable path an…

b927ee9

…d change its name to herc-plugins

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of dbghelpplug plugin for windows

0d6dd34

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Source changes to correctly build on windows with cmake and required …

2dead8f

…changes for a 64bit build

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Removal of project files for MSVS

3ad1b96

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Update windows bat files to reflect the new default directory structure

a3a1bec

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Update bash scripts and athena-start to reflect new directory structure

0576fec

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Add missing options to linker for sanitized builds

fb4f982

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Addition of ENABLE_CLASSIC_AUTOSPELL option to cmake

e0c9c8e

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Update github actions to work with the new cmake setup

88188c5

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Remove xcode and mac specific files

713273e

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>


          Change gcc-snapshot CI build to just current gcc and make it the main…

83cf2ba

… sanitizer build as conan doesn't support preview releases

Signed-off-by: Ibrahim Zidan <brahem@aotsw.com>

hemagx force-pushed the cmake branch from 995808a to 83cf2ba Compare

June 14, 2026 02:30

hemagx requested a review from MishimaHaruna

June 14, 2026 03:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet