Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces dark mode, macOS support, and CI/macOS build integration.
- Add dark theme colors to Vuetify configuration
- Implement theme switcher UI and persistence in App.vue
- Extend appDataCleaner and packaging to support macOS, update docs and workflows
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/renderer/main.js | Added dark theme color palette |
| src/renderer/components/DeveloperCleaner/CacheGroup.vue | Replaced hard-coded classes with theme-aware computed props |
| src/renderer/App.vue | Added theme toggle menu, logic, and persistence |
| src/main/appDataCleaner.js | Included macOS Library and /tmp directories |
| package.json | Bumped version to 1.2.2, added build:mac and mac packaging |
| README.md | Document dark mode and macOS usage instructions |
| CHANGELOG.md | Added entries for macOS support (1.2.1) and dark mode (1.2.2) |
| .github/workflows/build-and-release.yml | Added build-macos job and macOS artifact handling |
Comments suppressed due to low confidence (1)
src/renderer/App.vue:67
- Consider adding unit tests for the new theme switching logic (e.g.,
applyTheme,getThemeIcon, and persistence viawatch) to ensure correct behavior and localStorage interaction.
const themeMode = ref('system') // 'light', 'dark', 'system'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.