-
-
Notifications
You must be signed in to change notification settings - Fork 479
[FEAT] Allow specify global proxy with environment variable for backend #4358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
looks like you are missing the binaries? are you generating an app image? make sure you run |
Allow the user to specify a proxy server for backend requests with `GLOBAL_AGENT_HTTP_PROXY`.
Use standard proxy environment variables when given, instead of customized ones by the lib.
This make everything works, thanks. It works smoothly for me and I think it's ready for review now. |
Btw, debugging with |
Allow the user to specify a proxy server for backend requests (the ones using axios) with normal proxy envs like
http_proxy
,https_proxy
orall_proxy
.This allows the user to specify a global proxy server for making requests. Provides a solution for #3085. This is essential for some poorly routed or DNS polluted area (like Mainland China), where users may have trouble connecting to Github or game stores, or have really poor download speed. In this case they have to use a proxy server to get them work.
This may not be the best solution but should be the simplest one.
I've tested Wine installation and it works fine. However when I tried to login, it fails with following error. I think I'm missing some relevant toolsets, and since this also happens before I make these changes, I assume it's not caused by my changes. Please let me know if I'm missing something or you get into any problem.
Use the following Checklist if you have changed something on the Backend or Frontend: