Skip to content

[UX] Copy fake EpicGamesLauncher.exe for games flagged with env variable (like Rockstar games) #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arielj
Copy link
Collaborator

@arielj arielj commented Mar 4, 2025

This PR depends on having the legendary binary from: Heroic-Games-Launcher/legendary#13

How to test:

  • Install GTAV or RDR2 or any rockstar game
  • configure the custom legendary binary from the link above
  • make sure the game is NOT configure with the fix.bat workaround
  • set an env variable for the game USE_FAKE_EPIC_EXE=true
  • launch the game

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Copy link
Collaborator Author

@arielj arielj Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file is small enough and shouldn't really require changes in the future often, I think it's safe to include it in the build directly to make it simpler

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should still download this with the usual meta/downloadHelperBinaries.ts script, if nothing else than to track where this EXE comes from (I assume right now it's https://github.com/Etaash-mathamsetty/heroic-epic-integration/releases/tag/v0.3?)

@arielj arielj marked this pull request as ready for review April 1, 2025 01:22
@arielj arielj changed the title Copy fake EpicGamesLauncher.exe for games flagged with env variable [UX] Copy fake EpicGamesLauncher.exe for games flagged with env variable (like Rockstar games) Apr 1, 2025
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 7, 2025
@arielj arielj requested review from Etaash-mathamsetty, a team, flavioislima, CommandMC, Nocccer and imLinguin and removed request for a team April 7, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants