Skip to content

[UI] update new game page and theme colors #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

biliesilva
Copy link

@biliesilva biliesilva commented Mar 17, 2025

UI/UX Improvements for Game Info Tabs

Changes Made:

  • Enhanced tab navigation visual design in-game info section
  • Improved background transparency for better readability
  • Removed unnecessary indicator lines from Material-UI tabs
  • Applied color variables with proper opacity for consistent theming
  • Adjusted padding and spacing for better visual hierarchy
  • Optimized tab container layout and border-radius
  • Removed Unnistal button as we already have this in the options menu, to keep pattern like Steam, GOG and Epic does.

Technical Details:

  • Used CSS color-mix for modern browsers with fallback support
  • Maintained theme consistency by using existing color variables
  • Improved accessibility by keeping text fully opaque while having semi-transparent backgrounds
  • Cleaned up redundant styles in tab components

Update

image


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@biliesilva biliesilva self-assigned this Mar 17, 2025
@biliesilva biliesilva requested review from arielj, imLinguin, flavioislima and CommandMC and removed request for arielj and imLinguin March 17, 2025 13:34
@biliesilva biliesilva changed the title UI] update new game page, and some the me colors [UI] update new game page, and some theme colors Mar 17, 2025
@biliesilva biliesilva requested a review from Nocccer March 17, 2025 16:33
@flavioislima flavioislima added the pr:ready-for-review Feature-complete, ready for the grind! :P label Mar 17, 2025
Copy link
Contributor

@Kajot-dev Kajot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, looks nice, especially those tabs design!

<ReportIssue gameInfo={gameInfo} />
</div>
</>
)}
{/* NEW DESIGN */}
{experimentalFeatures.enableNewDesign && (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old design is removed, but "new" design is still hidden behind a flag, which is disabled by default.. This makes the game page not render by default for everybody:
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this catch! I will remove it! :)

{t('button.uninstall', 'Uninstall')}
</span>
</button>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uninstall button is removed entirely and it's not mentioned in the changes made. Is this intentional?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I removed it because we already have an uninstall in the options and clicking in the game card. The reason behind that was that before, we didn't have this button there, and Steam, Epic, and GOG keep this in the settings/options menu, which is not so explicit. I will mention this is the PR description, Thanks!

--primary-active: #0db4be;
--status-warning: #f8ae79;
--status-danger: #f97881;
--status-info: #2ceac7;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the changes in colors "pause/cancel install" button has the same bg as the icon and it's grey although it's clickable
image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't change the icon colors or this button color in particular, nor did I make any drastic color changes, just contrast and brightness, and added new color variables. As I said below, I have to test and fix the theme colors we have now because some have some problems like this.
image

--brand-secondary: #bfb3ff;
--brand-secondary-hover: #dad5ff;
--brand-text-01: #caf3fd;
--brand-text-02: #a5edfd;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Colors in light mode (Nord Light) are broken:
image

@@ -907,8 +529,6 @@
object-fit: cover;
filter: blur(15px);
opacity: 0.3;
/* scale is so there will be no ugly edges because of the blur */
transform: scale(1.1);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the background color leaking on edges when game splash contrasts with background color fixed in some other way?

@Kajot-dev
Copy link
Contributor

Are most of the colors changed? I'm not a maintainer, but there is a Figma for this: https://www.figma.com/design/Zv89aBtLJ8yN4BwFS0AwNb/Heroic-Games-Launcher---UI-LIBRARY?node-id=3509-19224&p=f

'main extra'
'report report';

padding: var(--space-lg);
height: 100vh;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed (height) and now, there is some weird padding on a larger screens:
image

Because of lack of the min-height page does not become scrollable on smaller, screen it just breaks:
image

Copy link
Author

@biliesilva biliesilva Apr 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the height, but I've put a max-height. The first example is intentional.

Could you share with me the size you tested? Because I also added a media query for the Steam Deck screen size.

Also, the scrollables live inside each table wrapper, as you can see in this picture you shared for example.

Here how it looks like in an example which the media for Steam Deck:
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on a 16:10 4K screen

@Kajot-dev
Copy link
Contributor

Oh and the report link is no longer centered at all, is this intentional?

@Kajot-dev
Copy link
Contributor

The background image is now centered to the whole screen instead of just the gamepage content:

Before:
image

After:
image

@biliesilva
Copy link
Author

Are most of the colors changed? I'm not a maintainer, but there is a Figma for this: https://www.figma.com/design/Zv89aBtLJ8yN4BwFS0AwNb/Heroic-Games-Launcher---UI-LIBRARY?node-id=3509-19224&p=f

Yeah, I made these designs, and these color themes was made some years ago in the first designs before I came up with this new design, I'm planning to fix/improve each color theme but in another PR.

@biliesilva
Copy link
Author

Oh and the report link is no longer centered at all, is this intentional?

Yes, because we have a modal that appears when we have an alert card for the game with anti-cheat on the other side, so for better visualisation is better not to leave this in the middle.

@biliesilva biliesilva changed the title [UI] update new game page, and some theme colors [UI] update new game page and theme colors Apr 5, 2025
@flavioislima
Copy link
Member

@biliesilva
Testing here, everything is looking promising and its working fine. Found only some issues with the Install button on some themes:

Midnight mirage:
image

Old School Heroic:
image

Dracula:
image

Marine and Marine Classic:
image

Zombie and zombie classic:
image

GRUVBOX:
image

Sweet:
image

@flavioislima
Copy link
Member

Those also apply to the Install button on the install modal and the pause button:
image

image

@Kajot-dev
Copy link
Contributor

Now, scroll is always enabled and I'm able to scroll through the sidebar:
image

TLDR scroll is triggered when it should not be and wrong element is scrollable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants