-
-
Notifications
You must be signed in to change notification settings - Fork 480
[UI] update new game page and theme colors #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[UI] update new game page and theme colors #4424
Conversation
…sses and responsiveness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, looks nice, especially those tabs design!
<ReportIssue gameInfo={gameInfo} /> | ||
</div> | ||
</> | ||
)} | ||
{/* NEW DESIGN */} | ||
{experimentalFeatures.enableNewDesign && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this catch! I will remove it! :)
{t('button.uninstall', 'Uninstall')} | ||
</span> | ||
</button> | ||
)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uninstall button is removed entirely and it's not mentioned in the changes made. Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I removed it because we already have an uninstall in the options and clicking in the game card. The reason behind that was that before, we didn't have this button there, and Steam, Epic, and GOG keep this in the settings/options menu, which is not so explicit. I will mention this is the PR description, Thanks!
--primary-active: #0db4be; | ||
--status-warning: #f8ae79; | ||
--status-danger: #f97881; | ||
--status-info: #2ceac7; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--brand-secondary: #bfb3ff; | ||
--brand-secondary-hover: #dad5ff; | ||
--brand-text-01: #caf3fd; | ||
--brand-text-02: #a5edfd; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -907,8 +529,6 @@ | |||
object-fit: cover; | |||
filter: blur(15px); | |||
opacity: 0.3; | |||
/* scale is so there will be no ugly edges because of the blur */ | |||
transform: scale(1.1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the background color leaking on edges when game splash contrasts with background color fixed in some other way?
Are most of the colors changed? I'm not a maintainer, but there is a Figma for this: https://www.figma.com/design/Zv89aBtLJ8yN4BwFS0AwNb/Heroic-Games-Launcher---UI-LIBRARY?node-id=3509-19224&p=f |
'main extra' | ||
'report report'; | ||
|
||
padding: var(--space-lg); | ||
height: 100vh; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the height, but I've put a max-height. The first example is intentional.
Could you share with me the size you tested? Because I also added a media query for the Steam Deck screen size.
Also, the scrollables live inside each table wrapper, as you can see in this picture you shared for example.
Here how it looks like in an example which the media for Steam Deck:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested on a 16:10 4K screen
Oh and the report link is no longer centered at all, is this intentional? |
Yeah, I made these designs, and these color themes was made some years ago in the first designs before I came up with this new design, I'm planning to fix/improve each color theme but in another PR. |
Yes, because we have a modal that appears when we have an alert card for the game with anti-cheat on the other side, so for better visualisation is better not to leave this in the middle. |
…cGamesLauncher into UI]-update-new-Game-Page,-and-some-the-me-colors
@biliesilva |
UI/UX Improvements for Game Info Tabs
Changes Made:
Technical Details:
Update
Use the following Checklist if you have changed something on the Backend or Frontend: