[FIX] Update DXVK on new releases

[Etaash-mathamsetty]

should fix #4432

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[casasfernando]

Thanks a lot for the quick response to the issue with this PR.

Out of curiosity, is the if really needed? Isn't the isOnline check already handled here:

HeroicGamesLauncher/src/backend/tools/index.ts

Line 138 in 3ec21de

if (!isOnline()) {

On which scenario is this code path executed? Every time an application/game is launched that has the DXVK auto install/update setting turned on?
What was the problem with checking for DXVK updates once on HGL start up? Was it the online/offline status that created the annoying popup?

Thanks

[arielj]

Thanks a lot for the quick response to the issue with this PR.

Out of curiosity, is the if really needed? Isn't the isOnline check already handled here:

HeroicGamesLauncher/src/backend/tools/index.ts

Line 138 in 3ec21de

if (!isOnline()) {

On which scenario is this code path executed? Every time an application/game is launched that has the DXVK auto install/update setting turned on? What was the problem with checking for DXVK updates once on HGL start up? Was it the online/offline status that created the annoying popup?

Thanks

I think the issue with doing that at boot is that it doesn't need to be downloaded if you use proton (and it's now the recommended compatibility layer to use) and also on mac if you use crossover or gptk it's also not needed.

So instead of downloading it for everyone (even if never used), I understand it was changed to only download it when it's actually used (unless I'm missing something).

[casasfernando]

I see. I’m wondering if it wouldn’t be better to have a global setting to turn dxvk updates on boot on/off (it could be off by default).
This way people that use it can turn it on and people that doesn’t is not affected.
I’m not really convinced to check for updates every time a game/app is launched.

Toughts?

[Etaash-mathamsetty]

I see. I’m wondering if it wouldn’t be better to have a global setting to turn dxvk updates on boot on/off (it could be off by default). This way people that use it can turn it on and people that doesn’t is not affected. I’m not really convinced to check for updates every time a game/app is launched.

Toughts?

i think it should be ok, it doesn't download anything, just checks that if what it the version of what it would be downloading is different than the version of that is currently installed. The code only runs if wine is used and not when proton/gptk/crossover is being used either

[flavioislima]

lgtm