Pick local files with file picker for Game Image

[sandepten]

Hey, I have added the ability to pick local files with file picker for Game Image (issue #4464)

Use the following Checklist if you have changed something on the Backend or Frontend:

• Tested the feature and it's working on a current and clean install.
• Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
• Created / Updated Tests (If necessary)
• Created / Updated documentation (If necessary)

[flavioislima]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[sandepten]

I have read the CLA Document and I hereby sign the CLA

[Copilot]

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

[flavioislima]

Hi! Thanks for tackling this issue.

One small thing, can you update the text inside the input?
Maybe to something like "Paste an URL of an Image or select one from your computer".

[sandepten]

Hi @flavioislima, I have updated the text inside the input

[imLinguin]

It may be a good idea to explicitly copy the image to some Heroic owned location. I imagine in cases like flatpak, Heroic may not have constant access to the location user selected

[flavioislima]

It may be a good idea to explicitly copy the image to some Heroic owned location. I imagine in cases like flatpak, Heroic may not have constant access to the location user selected

I wonder if this could happen if the app had access to pick the file at first. So unless that permission is revoked manually, I don't think that could happen, right?

[flavioislima]

Code Looks good, still need testing though.

[imLinguin]

It may be a good idea to explicitly copy the image to some Heroic owned location. I imagine in cases like flatpak, Heroic may not have constant access to the location user selected

I wonder if this could happen if the app had access to pick the file at first. So unless that permission is revoked manually, I don't think that could happen, right?

@flavioislima Not really, this can happen in every-day use. If the location is not accessible, the file picker will temporarily grant access to it through the portal, and make the file accessible in runtime location like $XDG_RUNTIME_DIR/doc/....
I think we should address cases like that