Skip to content

[Tech] Update to pnpm 10 #4488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Tech] Update to pnpm 10 #4488

wants to merge 6 commits into from

Conversation

CommandMC
Copy link
Collaborator

Somewhat of an offshoot of #4471, this extracts just the bits we need for pnpm 10

If you are on a Linux distro that doesn't have this version in their repos yet, you can use corepack (which comes with NodeJS) to install it for you. Simply run corepack enable, the next time you then run pnpm it'll auto-download the correct version. If you also lack corepack, see their README for install instructions.
Note that I've not tested whether this fully works (electron-builder has been rather peculiar about its environment). Ideally use your distro-provided package


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

The AppVeyor script shouldn't need this explicit `prepare`, as it can now infer
the version from the `packageManager` field
Not sure if we need all of these, but running them is the safer option
@CommandMC CommandMC added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 23, 2025
@CommandMC CommandMC requested a review from a team April 23, 2025 23:00
@CommandMC CommandMC self-assigned this Apr 23, 2025
@CommandMC CommandMC requested review from arielj, flavioislima, Nocccer and imLinguin and removed request for a team April 23, 2025 23:00
The action will also infer the version from `packageManager`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:ready-for-review Feature-complete, ready for the grind! :P
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant