-
-
Notifications
You must be signed in to change notification settings - Fork 551
Simplifying snapcraft.yaml #5113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is just proof that it's working. At the beginning of the video, all the existing plugs and those that are connected are shown; the steam-support plug is essential for the Proton/UMU-launcher to function. 2025-12-23.04-52-07.mp4 |
|
Testing the mangohud 2025-12-24.13-19-39.mp4 |
|
The feature to create game shortcuts in the application menu is working. 2025-12-24.17-02-33.mp4 |
CommandMC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no clue what half of the changes in this file do, but as I've mentioned elsewhere, I'm willing to try a Snap build again as long as it doesn't cause any major issues
| Heroic is an Open Source Games Launcher. Right now it supports launching games from the Epic Games | ||
| Store using Legendary, Amazon Games using Nile and GOG Games using our custom implementations Nile and gogdl. | ||
| version: 2.16.1 | ||
| version: 2.18.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we load this version number from package.json? Ideally we'd just have one version number to bump each update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely possible, but takes some script wrangling.
The other option would be to take another crack at using electron-build's native snap target, which brings in the version automatically.
| common-id: com.heroicgameslauncher.hgl | ||
| environment: | ||
| HOME: $SNAP_USER_COMMON | ||
| PATH: $SNAP/usr/games:$PATH |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is $SNAP/usr/games added to PATH here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the kde-neon-6 extension, this is set via desktop-launch, but this isn't done in the gnome extension, so I had to set it in snapcraft.yaml.
|
@Kyuyrii I will try to build this and publish it on snap store, would it work? Or this is just for the manual installation? for the manual installation we can distribute the .snap using the elctron builder we already have, would just need to adjust the release command: https://www.electron.build/snap |
To publish to the Snap Store, you need to request automatic connection of the steam-support plug; it is extremely important for UMU to function. |
|
Generally, plugs added to Snap apps that aren't connecting automatically don't prevent them from being published, but there are some exceptions for security reasons. |
I see, I think we had a thread somewhere at some point but I think I would need to start a new one. |
The error was about not finding the desktop-launch-heroic file. Locally, this error didn't occur here, but I modified the command-chain source to see if it fixes the problem. |
I simplified the snapcraft.yaml file; it was absurdly large and complex before.
Now it's easier to build the Snap version, as it will use the .deb version as a base.
I was able to build, install, log into my account, download a game, and launch it.
Use the following Checklist if you have changed something on the Backend or Frontend: