-
-
Notifications
You must be signed in to change notification settings - Fork 551
Add pnpm audit workflow #5118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add pnpm audit workflow #5118
Conversation
| - name: Setup pnpm 10.9.0 | ||
| uses: pnpm/action-setup@v3 | ||
| with: | ||
| version: 10.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the pnpm action will pull the version from package.json, you shouldn't have to specify it
| - name: Use Node 20 | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
current version of electron uses node 22, should audit against that
|
I don't think pnpm audit is that useful in our case, at least not as something that should block merging PRs like... if I'm working on something and some version of a new tool is released fixing some new known vulnerability, I don't want to have to update it in my totally unrelated PR just because pnpm audit says its critical, it's not related to my PR |
|
@arielj fair point! |
Testing/impact: Workflow-only change; no runtime code touched.