Skip to content

Conversation

@niStee
Copy link

@niStee niStee commented Dec 25, 2025

  • Add pnpm audit workflow on PRs to main/stable and weekly (Wed 04:15 UTC).
  • Use Node 20 and pnpm 10.9.0 (pnpm cache) with pnpm install --frozen-lockfile.
  • Run two audits: full pnpm audit --prod (captured to summary) and enforcing pnpm audit --prod --audit-level=high (fails on high/critical). Summary always shows all severities.
  • Minimal permissions (contents: read). Actions tag-pinned; Renovate will handle digest pinning Add conservative Renovate configuration with gated majors #5116.

Testing/impact: Workflow-only change; no runtime code touched.

@niStee niStee changed the title Add pnpm audit workflow (report-only) Add pnpm audit workflow Dec 25, 2025
- name: Setup pnpm 10.9.0
uses: pnpm/action-setup@v3
with:
version: 10.9.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the pnpm action will pull the version from package.json, you shouldn't have to specify it

- name: Use Node 20
uses: actions/setup-node@v4
with:
node-version: 20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current version of electron uses node 22, should audit against that

@arielj
Copy link
Collaborator

arielj commented Dec 30, 2025

I don't think pnpm audit is that useful in our case, at least not as something that should block merging PRs

like... if I'm working on something and some version of a new tool is released fixing some new known vulnerability, I don't want to have to update it in my totally unrelated PR just because pnpm audit says its critical, it's not related to my PR

@niStee
Copy link
Author

niStee commented Dec 30, 2025

@arielj fair point!
You shouldn't be blocked on unrelated pull requests.
I've updated this PR so that it's just for information. Even if a high-priority or critical issue is found, it won't prevent merging (unless we make it a required check in the repository settings, which we shouldn't do).
It's just a 'heads up' for the team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants