Skip to content

Add ESLint SARIF upload to lint workflow #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
niStee wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add ESLint SARIF upload to lint workflow #5121

niStee wants to merge 8 commits into from

Conversation

@niStee
Copy link

@niStee niStee commented Dec 26, 2025

  • Update lint workflow to publish ESLint findings to Code Scanning.
  • Permissions: contents: read, security-events: write.
  • Steps: run existing pnpm lint/prettier/deadcode, generate ESLint JSON, convert to SARIF via [email protected], and upload with github/codeql-action/upload-sarif@v3.
  • Actions remain tag-pinned; Renovate will handle digest pinning if configured (Add conservative Renovate configuration with gated majors #5116).

Testing/impact: Workflow-only change; no runtime code touched.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 26, 2025
View reviewed changes
.github/workflows/lint.yml

permissions:
contents: read
security-events: write

Check failure

Code scanning / Scorecard

Token-Permissions

score is 0: topLevel 'security-events' permission set to 'write' Remediation tip: Visit [https://app.stepsecurity.io/secureworkflow](https://app.stepsecurity.io/secureworkflow/file://./lint.yml/unknown?enable=permissions). Tick the 'Restrict permissions for GITHUB_TOKEN' Untick other options NOTE: If you want to resolve multiple issues at once, you can visit [https://app.stepsecurity.io/securerepo](https://app.stepsecurity.io/securerepo) instead. Click Remediation section below for further remediation help
.github/workflows/osv-scanner.yml Outdated

permissions:
contents: read
security-events: write

Check failure

Code scanning / Scorecard

Token-Permissions

score is 0: topLevel 'security-events' permission set to 'write' Remediation tip: Visit [https://app.stepsecurity.io/secureworkflow](https://app.stepsecurity.io/secureworkflow/file://./osv-scanner.yml/unknown?enable=permissions). Tick the 'Restrict permissions for GITHUB_TOKEN' Untick other options NOTE: If you want to resolve multiple issues at once, you can visit [https://app.stepsecurity.io/securerepo](https://app.stepsecurity.io/securerepo) instead. Click Remediation section below for further remediation help
.github/workflows/osv-scanner.yml Outdated
./
permissions:
contents: read
security-events: write

Check failure

Code scanning / Scorecard

Token-Permissions

score is 0: jobLevel 'security-events' permission set to 'write' Remediation tip: Visit [https://app.stepsecurity.io/secureworkflow](https://app.stepsecurity.io/secureworkflow/file://./osv-scanner.yml/unknown?enable=permissions). Tick the 'Restrict permissions for GITHUB_TOKEN' Untick other options NOTE: If you want to resolve multiple issues at once, you can visit [https://app.stepsecurity.io/securerepo](https://app.stepsecurity.io/securerepo) instead. Click Remediation section below for further remediation help
.github/workflows/lint.yml
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 0: GitHub-owned GitHubAction not pinned by hash Click Remediation section below to solve this issue
.github/workflows/lint.yml Outdated
- name: Convert ESLint JSON to SARIF
run: pnpm dlx [email protected] eslint-results.json > eslint-results.sarif
- name: Upload ESLint SARIF to code scanning
uses: github/codeql-action/upload-sarif@v3

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 0: GitHub-owned GitHubAction not pinned by hash Click Remediation section below to solve this issue
.github/workflows/scorecard.yml Outdated
security-events: write
id-token: write
steps:
- name: Checkout repository

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 0: GitHub-owned GitHubAction not pinned by hash Click Remediation section below to solve this issue
.github/workflows/scorecard.yml Outdated
with:
persist-credentials: false

- name: Run OSSF Scorecard

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 0: third-party GitHubAction not pinned by hash Click Remediation section below to solve this issue
.github/workflows/scorecard.yml Outdated
results_format: sarif
publish_results: true

- name: Upload SARIF to code scanning

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 0: GitHub-owned GitHubAction not pinned by hash Click Remediation section below to solve this issue
.github/workflows/scorecard.yml Outdated
with:
sarif_file: scorecard-results.sarif

- name: Upload Scorecard results artifact

Check warning

Code scanning / Scorecard

Pinned-Dependencies

score is 0: GitHub-owned GitHubAction not pinned by hash Click Remediation section below to solve this issue
@github-advanced-security
Copy link

github-advanced-security bot commented Dec 26, 2025

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@niStee