Skip to content

Conversation

@a5ehren
Copy link
Contributor

@a5ehren a5ehren commented Dec 30, 2025

…locations instead of just assuming that /proton exists. This fixes an issue that cachyos is about to file


Use the following Checklist if you have changed something on the Backend or Frontend:

  • [ x ] Tested the feature and it's working on a current and clean install.
  • [ x ] Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@a5ehren a5ehren force-pushed the cachy-proton branch 2 times, most recently from cac582a to 6a76fa1 Compare December 30, 2025 22:40
@a5ehren
Copy link
Contributor Author

a5ehren commented Dec 31, 2025

CI runner is failing because the gh action installs Node 20, but the globSync API does not exist until Node 22.

test:ci task should start passing once #5097 is done

@a5ehren a5ehren force-pushed the cachy-proton branch 2 times, most recently from b124d98 to bf2ed46 Compare January 4, 2026 19:45
Comment on lines 219 to 224
})
}
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use early return / inverted if conditions to avoid excessive indentation like this

For example, instead of

if (someCondition) {
  // Further logic
}

instead use

if (!someCondition) return // Or "continue", or error handling, depending on context
// Further logic, now with one less indentation level

You can further improve the code by using async code (I particularly like Promise.try to avoid a classic try/catch statement), but I understand this may be difficult if you're not used to it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that I forgot to push after changing to GlobSync for finding the files. I'll push that and then look at the async.

…locations instead of just assuming that <path>/proton exists. This fixes an issue with cachyos packaging of their native proton. Also adds a test for the new code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants