Skip to content

Conversation

@redromnon
Copy link
Collaborator

There's already a System Requirements section in the Tab view. Thus, it doesn't help to keep the same option in the sub menu.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

Remove system requirements option in the game's sub menu because the main tab view already includes this
@flavioislima
Copy link
Member

flavioislima commented Dec 31, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@redromnon redromnon added the pr:ready-for-review Feature-complete, ready for the grind! :P label Dec 31, 2025
@redromnon
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

@arielj
Copy link
Collaborator

arielj commented Jan 3, 2026

I'm not sure if having the duplicated option to see the requirements is a problem, we also have the browse files and browse wine prefix links that are duplicated and I don't think it's an actual issue (users may find it easier to find things inside the 3-dots menu)

like... if a user has a narrow screen, it might be not obvious that there's a System Requirements tab on that right pane

Captura de pantalla 2026-01-03 a la(s) 6 01 16 p  m

@redromnon
Copy link
Collaborator Author

redromnon commented Jan 4, 2026

Makes sense. Some users may prefer using the three-dots menu. It would prefer to use the Monitor icon instead of the DesktopAccessDisabledIcon in the menu.

On another note:

like... if a user has a narrow screen, it might be not obvious that there's a System Requirements tab on that right pane

For this issue, can a scrollbar be added to tell the user that another tab exists? Here's an example of this, where the user wouldn't know the System Requirements tab exists unless there's a scrollbar present.
Screenshot From 2026-01-04 12-15-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants