Fix #4699: Read no more than the last 1 MB of log files to be shown#5457
Open
thatguywiththekids wants to merge 9 commits intoHeroic-Games-Launcher:mainfrom
Open
Fix #4699: Read no more than the last 1 MB of log files to be shown#5457thatguywiththekids wants to merge 9 commits intoHeroic-Games-Launcher:mainfrom
thatguywiththekids wants to merge 9 commits intoHeroic-Games-Launcher:mainfrom
Conversation
Member
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
thatguywiththekids
changed the title
thatguywiththekids
changed the title
flavioislima
requested review from
a team,
CommandMC,
Etaash-mathamsetty,
arielj,
biliesilva,
flavioislima and
imLinguin
and removed request for
a team
flavioislima
added
the
pr:ready-for-review
CommandMC
reviewed
Apr 7, 2026
arielj
reviewed
Apr 9, 2026
thatguywiththekids
force-pushed
the
dont-crash-on-large-logs
branch
from
720fe07 to
3257a95
Compare
Author
|
Reviews by @CommandMC and @arielj have been acted upon. |
Author
|
Are the reviewers OK with the changes now? |
CommandMC
reviewed
Apr 25, 2026
CommandMC
approved these changes
Apr 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4699 by only reading the last 1 MB of log files.
Use the following Checklist if you have changed something on the Backend or Frontend: