Conversation
arielj
requested review from
a team,
CommandMC,
Etaash-mathamsetty and
flavioislima
and removed request for
a team
| release_data.download = asset.browser_download_url | ||
| release_data.downsize = asset.size | ||
| // for proton-cachyos we want to always get the main x86 asset, | ||
| // the other logic sometimes gets the V3, V4 or arm asset incorrectly |
There was a problem hiding this comment.
proton-cachyos releases has many assets (arm and different x86 versions). The recommendation is to not use the V3/V4 assets since they may be less stable, we have to ensure we install the stable asset for x86
|
|
||
| const configStore = new TypeCheckedStoreFrontend('wineManagerConfigStore', { | ||
| cwd: 'store' | ||
| }) |
There was a problem hiding this comment.
I had to remove the use of this electron store because there's no way to update its stored value and it ignores new repositories added.
I understand this was saved in a store to not have to loop through the other OS repositories when rendering the tabs? but it's not really helping
|
@arielj from user's perspective, everything seems to work fine when testing.
|
| } | ||
| if (any_gpu_supports_version([1, 1, 0])) { | ||
| logInfo( | ||
| 'The GPU(s) in this system only support Vulkan 1.1/1.2, falling back to DXVK 1.10.3', |
There was a problem hiding this comment.
This route shouldnt be called when using Proton. What's the intention here?
Do we want a separate feature for enabling this automatically for Proton CachyOS?
There was a problem hiding this comment.
We are calling DXVK.getLatest() when heroic opens (and it calls this internally), independent of what we have configured for a game, this prints in the general logs information for the user to know they have a GPU that does not support Vulkan 1.3+.
Then if they see that in the logs they know they have to use proton-cachyos instead of ge-proton.
There was a problem hiding this comment.
this is also called when running a game with wine I think when it installs DXVK, but I'm adding this information for that use case of the DXVK update when heroic is started
There was a problem hiding this comment.
I do think we should have something automated in another PR, yes, and make this more visible for the user, I opened an issue here #5425
We could even use this information to default to proton-cachyos with the dxvk-sarek env variable instead of ge-proton if the gpu does not support vulkan 1.3+, but I think all that would be a different feature (would mean moving this check somewhere more global to check once and reuse in other places and also the frontend)
3 participants
This PR adds proton-cachyos as an option to download in the Wine Manager, this replaces #5424
The benefits of proton-cachyos are:
I updated the releases-info repo to also check cachyos https://github.com/Heroic-Games-Launcher/releases-info/blob/main/release-data.json#L34
I'll add some extra notes in the diff
I think we can later add some feature for users to enable the DXVK alternatives from the UI without the need of env variables, but I think that would be out of the scope of this PR, we can instruct users to use the env variable.
Use the following Checklist if you have changed something on the Backend or Frontend: