Skip to content

[FIX] Do not watch legendary file to refresh the lilbrary#5470

Open
arielj wants to merge 2 commits intomainfrom
do-not-watch-legendary-installed
Open

[FIX] Do not watch legendary file to refresh the lilbrary#5470
arielj wants to merge 2 commits intomainfrom
do-not-watch-legendary-installed

Conversation

@arielj
Copy link
Copy Markdown
Collaborator

@arielj arielj commented Apr 7, 2026

We are always starting a watcher for changes in the legendary installed json file.

This has a few issues:

  • it triggers a refresh of the installed games in a different way than the rest of the stores (it's done with an async watcher instead of sync right after the installation ends)
  • we are always trying to add the watcher even if the file does not exist, showing an error in the logs (this added confusion to users that do not use Epic games)
  • the code had a workaround for a known issue with the watch function that it could be triggered twice while the file was being written, it was extra complexity
  • the watcher was always added, even when not doing anything that would change this file like when running a game with no GUI, using resources for no reason

This PR removes that and uses a similar approach as the other stores: once the game is installed, we refresh the installed games in the backend and the frontend was already triggering a refresh.

I tried installing and uninstalling a game and it updates the frontend correctly.


Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@arielj arielj requested review from a team, CommandMC, Etaash-mathamsetty, biliesilva, flavioislima and imLinguin and removed request for a team April 7, 2026 22:59
@arielj arielj added the pr:ready-for-review Feature-complete, ready for the grind! :P label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:ready-for-review Feature-complete, ready for the grind! :P

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant