[FIX] Do not watch legendary file to refresh the lilbrary#5470
Open
[FIX] Do not watch legendary file to refresh the lilbrary#5470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are always starting a watcher for changes in the legendary installed json file.
This has a few issues:
watchfunction that it could be triggered twice while the file was being written, it was extra complexityThis PR removes that and uses a similar approach as the other stores: once the game is installed, we refresh the installed games in the backend and the frontend was already triggering a refresh.
I tried installing and uninstalling a game and it updates the frontend correctly.
Use the following Checklist if you have changed something on the Backend or Frontend: