[Feat] Option to hide Heroic window on heroic:// launches (#5154)#5501
Open
flavioislima wants to merge 6 commits intomainfrom
Open
[Feat] Option to hide Heroic window on heroic:// launches (#5154)#5501flavioislima wants to merge 6 commits intomainfrom
flavioislima wants to merge 6 commits intomainfrom
Conversation
New AppSettings field (default false) that will be read by the protocol handler to decide whether to skip showing the main window on heroic:// launches.
Support two ways to launch a game via the heroic:// protocol without popping up the main window: - per-URL `gui=false` (also `gui=0` / `gui=no`) query parameter - the new `hideWindowOnProtocolLaunch` global setting The hide logic runs in three places: startup (include it in the `headless` computation), second-instance (skip the forced `mainWindow.show()`), and inside `handleLaunch` (hide the already-visible window after dispatching the launch). When the game is not installed, the install dialog still needs the window, so it is shown.
New toggle under General settings so users can opt into skipping the Heroic window for all heroic:// launches, plus the matching English translation string.
…ve from GeneralSettings
Briefly explains the use case (launching from external shortcuts like Steam's 'Add to Steam') so users know what the toggle does without having to read the docs.
flavioislima
force-pushed
the
feat/protocol_no_gui
branch
from
9e4e2ae to
1dbf9c9
Compare
flavioislima
added
pr:ready-for-review
flavioislima
requested review from
a team,
CommandMC,
Etaash-mathamsetty,
arielj,
biliesilva and
imLinguin
and removed request for
a team
# Conflicts: # src/frontend/screens/Settings/sections/AdvancedSettings/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #5154. Lets users launch games via
heroic://URLs without the Heroic window appearing first — handy when launching from Steam Big Picture, other frontends, or.desktopshortcuts.Two complementary knobs:
Hide Heroic window when launching games from heroic:// linkstoggle under Settings → General (default off).gui=false(also acceptsgui=0/gui=no) to anyheroic://launchURL, e.g.heroic://launch?appName=Quail&runner=legendary&gui=false.Either source is respected in three places:
mainWindow.show())If the game is not installed, the install confirmation dialog still pops the window, since it needs user input.
Test plan
heroic://launch?appName=…&gui=falseand confirm window stays hiddenheroic://launch?appName=…with setting off and confirm default behaviour is unchangedheroic://launch/<uninstalled-game>with hide enabled; confirm install dialog still shows the window