Add sounds to interactions in Console Mode#5535
Open
michelonfelipe wants to merge 1 commit intoHeroic-Games-Launcher:mainfrom
Open
Add sounds to interactions in Console Mode#5535michelonfelipe wants to merge 1 commit intoHeroic-Games-Launcher:mainfrom
michelonfelipe wants to merge 1 commit intoHeroic-Games-Launcher:mainfrom
Conversation
all sounds come from https://pixabay.com so are free from copyright and can be used in an app like Heroic
Member
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I really like console mode, but i missed something that was present in other interfaces like that: sounds
How
trueby default.Sound license
All audio samples come from pixabay which allows usage of their media (more details in their license page), even without having to attribute the author. The audios used were the following (some were lightly edited):
Evidences
Video with sounds
output.mp4
New setting for disabling sound
Use the following Checklist if you have changed something on the Backend or Frontend: