[Console] Several QoL fixes for Console Mode#5595
Open
veryprofessionaldodo wants to merge 2 commits into
Open
Conversation
|
Do you think you could implement this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR improves some console mode things, but it's mostly minor stuff:
onMouseEnter. Previously, if the mouse was somewhere in the active zone, but we were using a gamepad to scroll through the list, whenever the card would be behind the cursor it would automatically focus itself, making for a weird UX. Now we only trigger the mouse focus event when if the mouse is above a card, and starts moving;focusedIndexto be less than 0. When this happens, we assume we're in the top bar, and give no focus to any card. When we press down to return back to the game list, it returns to the card we lost focus in. This way we can actually have no card be focused, which we previously didn't allow;console-ignore-backto theclassListto prevent that behavior from triggering;Here's how it's working at the moment:
updated.mp4