[Fix] macOS app menu showing "heroic" in lowercase #5238#5648
Open
MateoGonzalezLourido wants to merge 1 commit into
Open
[Fix] macOS app menu showing "heroic" in lowercase #5238#5648MateoGonzalezLourido wants to merge 1 commit into
MateoGonzalezLourido wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<--- Put the description here --->
related to #5238
The menu bar title ("Heroic" in bold) was already correct becau
se Electron reads
CFBundleNamefromInfo.plist, which electron-builder sets from
productName: Heroicinelectron-builde r.yml.However, the dropdown items ("About", "Hide", "Quit") are gener
ated by Electron using
app.getName(), which returns thenamefield frompackage.json—"heroic"(lowercase, as is conventional for npm packages).
Fix
Added a single
app.setName()call for macOS insrc/backend/m ain.ts, mirroring the existing Windows fix:This overrides
app.getName()at runtime so Electron uses thecorrectly capitalized name when generating the native macOS men
u items.
Use the following Checklist if you have changed something on the Backend or Frontend: