Skip to content

[Fix] macOS app menu showing "heroic" in lowercase #5238#5648

Open
MateoGonzalezLourido wants to merge 1 commit into
Heroic-Games-Launcher:mainfrom
MateoGonzalezLourido:fix/capitalice-context-menu-macos
Open

[Fix] macOS app menu showing "heroic" in lowercase #5238#5648
MateoGonzalezLourido wants to merge 1 commit into
Heroic-Games-Launcher:mainfrom
MateoGonzalezLourido:fix/capitalice-context-menu-macos

Conversation

@MateoGonzalezLourido

Copy link
Copy Markdown

<--- Put the description here --->
related to #5238

The menu bar title ("Heroic" in bold) was already correct becau
se Electron reads CFBundleName from Info.plist, which elect
ron-builder sets from productName: Heroic in electron-builde r.yml.

However, the dropdown items ("About", "Hide", "Quit") are gener
ated by Electron using app.getName(), which returns the name field from package.json"heroic" (lowercase, as is conv
entional for npm packages).

Fix

Added a single app.setName() call for macOS in src/backend/m ain.ts, mirroring the existing Windows fix:

if (isWindows) {
  app.setAppUserModelId('Heroic Games Launcher')
}
if (isMac) {
  app.setName('Heroic')
}

This overrides app.getName() at runtime so Electron uses the
correctly capitalized name when generating the native macOS men
u items.

Use the following Checklist if you have changed something on the Backend or Frontend:

  • Tested the feature and it's working on a current and clean install.
  • Tested the main App features and they are still working on a current and clean install. (Login, Install, Play, Uninstall, Move games, etc.)
  • Created / Updated Tests (If necessary)
  • Created / Updated documentation (If necessary)

@MateoGonzalezLourido MateoGonzalezLourido changed the title Fix: macOS app menu showing "heroic" in lowercase #5238 [Fix] macOS app menu showing "heroic" in lowercase #5238 Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant