[Fix] Update status not updating when game starts processing#5658
Open
MateoGonzalezLourido wants to merge 2 commits into
Open
[Fix] Update status not updating when game starts processing#5658MateoGonzalezLourido wants to merge 2 commits into
MateoGonzalezLourido wants to merge 2 commits into
Conversation
is updated correctly
is being prepared
Author
|
Until a game has updates, I can't test the fix; it should work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<--- Put the description here --->
When a game was already updating, calling addToQueue again (e.g. from a background refreshLibrary with autoUpdate) would unconditionally send status: 'queued', overwriting the active update state on the frontend. The game would show "Queued" even though it was actively updating.
Changes
downloadqueue.ts: addToQueue no longer sends status: 'queued' if the element is currently being processed (isRunning() && currentElement matches the game). This preserves the real update state.
constants.ts: Updates no longer show 0% before progress data is available. The percentage is only shown once percent has a real value, so during the preparation phase it shows "Updating" instead of "Updating 0%"
Use the following Checklist if you have changed something on the Backend or Frontend: