[Fix] Avoid unnecessary network refresh after Legendary operations#5672
Open
MateoGonzalezLourido wants to merge 2 commits into
Open
Conversation
innecesario post install game de legendary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refreshLocal()method toLegendaryLibraryManagerthat refreshes the library reading only local files, skipping thelegendary listnetwork call.localOnlyoption toRefreshOptions,LibraryManager, IPC types, andGlobalState.refreshLibrary().localOnly: true. Game install state is always written to local files by Legendary before signaling completion, so the network call was redundant. Updates are excluded from this — they still trigger a full network refresh.Problem
After any Legendary operation finished,
refreshLibrarytriggered a full refresh which calledlegendary listagainst the Epic Games API. This was unnecessary: install state lives ininstalled.jsonand game metadata inlegendaryMetadata/*.json, both written locally by Legendary before it signals completion. The network call only serves to sync the account's game catalogue, which doesn't change as a result of local operations.Solution
refreshLocal()callsloadGamesInAccount(),refreshInstalled(), andloadAll()— all purely local file reads — then saves the result to the library store. ThelocalOnlyflag is optional onLibraryManagerso other store managers (GOG, Amazon) are unaffected. Game updates still go through the full network refresh sincecheckForUpdatesrequires up-to-date remote data.Use the following Checklist if you have changed something on the Backend or Frontend: