Support signed chunk download URLs #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommandMC
force-pushed
the
feat/token-download
branch
from
a9ff68c to
3728e9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for signed chunk download URLs, introduced by Epic a few days ago
To download chunks, Legendary now first requests a download ticket (with some relevant game metadata), and then runs chunk paths through another API to get signed URLs
This required quite a bit of inter-connectivity between the main & download manager processes; I've tried to keep this as clean as possible
I've confirmed both that games not using this system download fine with the old behavior, and games using the system download fine with the new.
Interestingly enough, games without this support still download fine if forced to use the system, and some even require it to download (reportedly this fixes Risk of Rain 2). To help in such cases, the
--always-use-signed-urlsparameter was added to the install command