Skip to content

Conversation

@danez
Copy link

@danez danez commented Jan 10, 2026

In my tests this fixes the build, i tested on macOS. I don't have windows, but can test on linux as well.

@CommandMC

Includes and fixes #27

Copy link
Member

@CommandMC CommandMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, thanks! I've just merged my workflow update PR (IMO it's easier to have the two changes in separate commits), I'll merge this as soon as you resolve the conflicts

I can confirm this fixes the build on Linux. I can't try Windows at the moment

danez added 2 commits January 11, 2026 01:23
# Conflicts:
#	.github/workflows/python.yml
@danez
Copy link
Author

danez commented Jan 11, 2026

Resolved.

@CommandMC CommandMC merged commit 019f23a into Heroic-Games-Launcher:master Jan 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants