Add opened .vue file to externalFiles#1
Open
doits wants to merge 1 commit into
Open
Conversation
Because vue file not imported from ts file are not included in project (cherry picked from commit e4f7c8c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because vue file not imported from ts file are not included in project
(cherry picked from commit e4f7c8c)
This fixes the problem about imports not found as discussed in dense-analysis/ale#927 (comment) and following.
Without it, imports of components in
.vuecomponents always triggered a2307: Cannot find module '@/components/Component.vue'.error.With this change, imports now don't trigger an error anymore. Though it seems now all imports of
.vuefiles are considered valid. E.g.:Since the project won't compile with such an error though, I think this is more acceptable to not display a linting error in this case instead of displaying wrong linting errors for existing files.
Anyway, maybe somebody with more experience can take a look at the change and maybe see why now all imports are considered valid, not only existing ones?