Fix: Artifact pull failing when running cmf init ssh#331
Open
AyeshaSanadi wants to merge 6 commits intoHewlettPackard:masterfrom
Open
Fix: Artifact pull failing when running cmf init ssh#331AyeshaSanadi wants to merge 6 commits intoHewlettPackard:masterfrom
AyeshaSanadi wants to merge 6 commits intoHewlettPackard:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues / Pull Requests
List all related issues and/or pull requests if there are any.
Description
Include a brief summary of the proposed changes.
What changes are proposed in this pull request?
sftp.put()(which uploads to remote) instead ofsftp.get()(which downloads from remote). Fixed in bothdownload_fileanddownload_directory.download_directoryinner loop: Original passedobject_name(the.dirmanifest path) tosftp.put()for every file instead oftemp_object_name(the individual file's content-addressed path).download_file: Original usedos.stat(object_name).st_size— a localstat()on a remote path string, which would fail. Fixed to use remote stat before download and local stat after._get_connection()+ auto-close via__del__.Checklist:
uses Google-style formatting and any other formatting that is supported by mkdocs and plugins this project
uses.