set save=true when consoleHost changes during VM sync

[ckeskar23]

After cloud sync, consoleHost appeared to be set in memory but was silently discarded. Subsequent console connections used a stale or missing host name because the updated value was never written to the database.

In VirtualMachineSync.updateMatchedVirtualMachines, the consoleHost field was assigned when it differed from the current value, but save was not set to true. Because the server is only persisted when save == true, the change was lost on every sync cycle.

morpheus-ui PR: #4352

Source Jira: MORPH-11002

UI commit: 0c7a1a6

[NimbleMike]

lgtm

[panigrap]

how about the other diff in the morpheus-ui PR ?
def rawUsername = server.zone.credentialData?.username ?: server.zone.getConfigProperty('username')
server.consoleUsername = rawUsername?.contains('\') ? rawUsername.tokenize('\')[1] : rawUsername

Plugin has this

def consoleUsername = cloud.accountCredentialData?.username ?: cloud.getConfigProperty('username') ?: 'dunno'
if (consoleUsername.contains('\')) {
consoleUsername = consoleUsername.tokenize('\')[1]
}

we are not defaulting to consoleUsername after tokenize.

[panigrap]

how about the other diff in the morpheus-ui PR ? def rawUsername = server.zone.credentialData?.username ?: server.zone.getConfigProperty('username') server.consoleUsername = rawUsername?.contains('') ? rawUsername.tokenize('')[1] : rawUsername

Plugin has this

def consoleUsername = cloud.accountCredentialData?.username ?: cloud.getConfigProperty('username') ?: 'dunno' if (consoleUsername.contains('')) { consoleUsername = consoleUsername.tokenize('')[1] }

we are not defaulting to consoleUsername after tokenize.

@ckeskar23 Did you get a chance to have a look into this comment ?

[ckeskar23]

how about the other diff in the morpheus-ui PR ? def rawUsername = server.zone.credentialData?.username ?: server.zone.getConfigProperty('username') server.consoleUsername = rawUsername?.contains('') ? rawUsername.tokenize('')[1] : rawUsername
Plugin has this
def consoleUsername = cloud.accountCredentialData?.username ?: cloud.getConfigProperty('username') ?: 'dunno' if (consoleUsername.contains('')) { consoleUsername = consoleUsername.tokenize('')[1] }
we are not defaulting to consoleUsername after tokenize.

@ckeskar23 Did you get a chance to have a look into this comment ?

Yes, I tried to addressed this in last commit, please let me know if there is any feedback on that, thanks!