Skip to content

fix(ci): resolve baseline typecheck errors blocking CI#6

Merged
HexaField merged 2 commits intomainfrom
fix/ci-baseline-typecheck-errors
Apr 14, 2026
Merged

fix(ci): resolve baseline typecheck errors blocking CI#6
HexaField merged 2 commits intomainfrom
fix/ci-baseline-typecheck-errors

Conversation

@HexaField
Copy link
Copy Markdown
Owner

Objective

Restore the current client CI baseline by fixing TypeScript check failures in WorkspaceView.tsx and aligning workspace tests/types with the current sidebar model.

Problem

The repository's CI check step currently fails in @sovereign/client during tsc --noEmit with:

  • Unused imports for threads/createThread in WorkspaceView.tsx
  • Invalid comparison against sidebar tab key 'threads'
  • Invalid property access on the value narrowed from Show in file-viewer branches

Changes

  • Remove unused thread-store imports from WorkspaceView.tsx
  • Remove stale 'threads' sidebar Match branch
  • Add type-safe active-tab memo helpers for file-viewer rendering
  • Update workspace tests to match current SidebarTab/SIDEBAR_TABS contract

Verification

  • pnpm run check now passes
  • Targeted workspace tests updated and passing

This fixes pre-existing CI baseline failures that were blocking all feature PRs.

- Remove unused thread-store imports from WorkspaceView.tsx
- Remove stale 'threads' sidebar Match branch
- Add type-safe active-tab memo helpers for file-viewer rendering
- Update workspace tests to match current SidebarTab/SIDEBAR_TABS contract
- Restore pnpm check to passing state

Fixes pre-existing CI baseline failures unrelated to feature PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant