Skip to content

Set foreign key constraints #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Draft

Set foreign key constraints #403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions common/src/main/java/net/draycia/carbon/common/users/db/DatabaseUserManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ private DatabaseUserManager(

@Override
public CarbonPlayerCommon loadOrCreate(final UUID uuid) {
return this.jdbi.withHandle(handle -> {
return this.jdbi.inTransaction(handle -> {
final @Nullable CarbonPlayerCommon carbonPlayerCommon = handle.createQuery(this.locator.query("select-player"))
.bind("id", uuid)
.mapTo(CarbonPlayerCommon.class)
Expand Down Expand Up @@ -170,7 +170,7 @@ public void saveSync(final CarbonPlayerCommon player) {

@Override
protected @Nullable PartyImpl loadParty(final UUID uuid) {
return this.jdbi.withHandle(handle -> {
return this.jdbi.inTransaction(handle -> {
final @Nullable PartyImpl party = this.selectParty(handle, uuid);
if (party == null) {
return null;
Expand Down Expand Up @@ -239,7 +239,6 @@ protected void saveSync(final PartyImpl party, final Map<UUID, PartyImpl.ChangeT
public void disbandSync(final UUID id) {
this.jdbi.useHandle(handle -> {
handle.createUpdate(this.locator.query("drop-party")).bind("partyid", id).execute();
handle.createUpdate(this.locator.query("clear-party-members")).bind("partyid", id).execute();
});
}

Expand Down
1 change: 0 additions & 1 deletion common/src/main/resources/queries/clear-party-members.sql
View file
Open in desktop

This file was deleted.

21 changes: 21 additions & 0 deletions common/src/main/resources/queries/migrations/h2/V4__add_constraints.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
ALTER TABLE carbon_ignores
ADD CONSTRAINT carbon_ignores_owner
FOREIGN KEY (id) REFERENCES carbon_users (id) ON DELETE CASCADE;
ALTER TABLE carbon_ignores
ADD CONSTRAINT carbon_ignores_ignored
FOREIGN KEY (ignoredplayer) REFERENCES carbon_users (id) ON DELETE CASCADE;

ALTER TABLE carbon_leftchannels
ADD CONSTRAINT carbon_leftchannels_owner
FOREIGN KEY (id) REFERENCES carbon_users (id) ON DELETE CASCADE;

ALTER TABLE carbon_party_members
ADD CONSTRAINT carbon_party_members_member
FOREIGN KEY (playerid) REFERENCES carbon_users (id) ON DELETE CASCADE;
ALTER TABLE carbon_party_members
ADD CONSTRAINT carbon_party_members_party
FOREIGN KEY (partyid) REFERENCES carbon_parties (partyid) ON DELETE CASCADE;

ALTER TABLE carbon_users
ADD CONSTRAINT carbon_users_party
FOREIGN KEY (party) REFERENCES carbon_parties (partyid) ON DELETE SET NULL;
21 changes: 21 additions & 0 deletions common/src/main/resources/queries/migrations/mysql/V8__add_constraints.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
ALTER TABLE carbon_ignores
ADD CONSTRAINT carbon_ignores_owner
FOREIGN KEY (id) REFERENCES carbon_users (id) ON DELETE CASCADE;
ALTER TABLE carbon_ignores
ADD CONSTRAINT carbon_ignores_ignored
FOREIGN KEY (ignoredplayer) REFERENCES carbon_users (id) ON DELETE CASCADE;

ALTER TABLE carbon_leftchannels
ADD CONSTRAINT carbon_leftchannels_owner
FOREIGN KEY (id) REFERENCES carbon_users (id) ON DELETE CASCADE;

ALTER TABLE carbon_party_members
ADD CONSTRAINT carbon_party_members_member
FOREIGN KEY (playerid) REFERENCES carbon_users (id) ON DELETE CASCADE;
ALTER TABLE carbon_party_members
ADD CONSTRAINT carbon_party_members_party
FOREIGN KEY (partyid) REFERENCES carbon_parties (partyid) ON DELETE CASCADE;

ALTER TABLE carbon_users
ADD CONSTRAINT carbon_users_party
FOREIGN KEY (party) REFERENCES carbon_parties (partyid) ON DELETE SET NULL;
21 changes: 21 additions & 0 deletions common/src/main/resources/queries/migrations/postgresql/V8__add_constraints.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
ALTER TABLE carbon_ignores
ADD CONSTRAINT carbon_ignores_owner
FOREIGN KEY (id) REFERENCES carbon_users (id) ON DELETE CASCADE;
ALTER TABLE carbon_ignores
ADD CONSTRAINT carbon_ignores_ignored
FOREIGN KEY (ignoredplayer) REFERENCES carbon_users (id) ON DELETE CASCADE;

ALTER TABLE carbon_leftchannels
ADD CONSTRAINT carbon_leftchannels_owner
FOREIGN KEY (id) REFERENCES carbon_users (id) ON DELETE CASCADE;

ALTER TABLE carbon_party_members
ADD CONSTRAINT carbon_party_members_member
FOREIGN KEY (playerid) REFERENCES carbon_users (id) ON DELETE CASCADE;
ALTER TABLE carbon_party_members
ADD CONSTRAINT carbon_party_members_party
FOREIGN KEY (partyid) REFERENCES carbon_parties (partyid) ON DELETE CASCADE;

ALTER TABLE carbon_users
ADD CONSTRAINT carbon_users_party
FOREIGN KEY (party) REFERENCES carbon_parties (partyid) ON DELETE SET NULL;