Skip to content

fix(frontend): require session to show protected pages#1190

Draft
yassinedorbozgithub wants to merge 1 commit intomainfrom
410-bug-extract-rendering-for-protected-paths-after-session-expiration
Draft

fix(frontend): require session to show protected pages#1190
yassinedorbozgithub wants to merge 1 commit intomainfrom
410-bug-extract-rendering-for-protected-paths-after-session-expiration

Conversation

@yassinedorbozgithub
Copy link
Collaborator

@yassinedorbozgithub yassinedorbozgithub commented Jul 3, 2025

Motivation

The main motivation of this PR are :

  • Require session to show protected pages

Fixes #410

Screen recording

require.session.to.show.protected.pages.webm

Type of change:

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Refactor
    • Updated the content layout to conditionally display content based on the current route and user authentication status. Content is now hidden unless the user is authenticated or accessing a public path.

@yassinedorbozgithub yassinedorbozgithub self-assigned this Jul 3, 2025
@yassinedorbozgithub yassinedorbozgithub added the bug Something isn't working label Jul 3, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 3, 2025

Walkthrough

The Content component in the frontend layout was refactored to use the Next.js useRouter hook and a custom useAuth hook, enabling conditional rendering of its children based on the current route and authentication state. Content is now displayed only if the route matches criteria defined by hasPublicPath or the user is authenticated; otherwise, it is hidden by setting the CSS display property to "none".

Changes

File(s) Change Summary
frontend/src/layout/content/index.tsx Refactored Content component to use useRouter and useAuth hooks for route- and authentication-based conditional rendering of children.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NextRouter
    participant ContentComponent
    participant hasPublicPath
    participant useAuth

    User->>ContentComponent: Accesses route
    ContentComponent->>NextRouter: Gets current pathname
    ContentComponent->>useAuth: Checks if authenticated
    ContentComponent->>hasPublicPath: Checks if pathname is public
    hasPublicPath-->>ContentComponent: Returns true/false
    useAuth-->>ContentComponent: Returns true/false
    alt Path is public or user is authenticated
        ContentComponent->>User: Renders children (display: block)
    else Path is not public and user not authenticated
        ContentComponent->>User: Hides children (display: none)
    end
Loading

Assessment against linked issues

Objective Addressed Explanation
Extract rendering for protected paths after session expiration (#410)

Possibly related PRs

  • fix(frontend): resolve infinite loading bug #1179: Both PRs involve the use of the hasPublicPath utility function to conditionally handle rendering or redirection based on the current pathname, linking their changes through shared route-based logic in the frontend.

Suggested labels

needs-review

Suggested reviewers

  • medchedli
  • marrouchi

Poem

A bunny hops through routes with glee,
Hiding content where it shouldn't be.
With useRouter and a clever check,
The layout's tidy—what the heck!
Now only public paths can show,
Or when you're logged in, off you go!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4d383ff and 16e9ca1.

📒 Files selected for processing (1)
  • frontend/src/layout/content/index.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • frontend/src/layout/content/index.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yassinedorbozgithub yassinedorbozgithub changed the title fix(frontend): required session to show protected pages fix(frontend): require session to show protected pages Jul 3, 2025
@yassinedorbozgithub yassinedorbozgithub marked this pull request as draft July 3, 2025 07:35
@yassinedorbozgithub yassinedorbozgithub force-pushed the 410-bug-extract-rendering-for-protected-paths-after-session-expiration branch from 4d383ff to 16e9ca1 Compare July 3, 2025 07:37
@yassinedorbozgithub yassinedorbozgithub marked this pull request as ready for review July 3, 2025 07:37
@yassinedorbozgithub yassinedorbozgithub marked this pull request as draft July 3, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - extract rendering for protected paths after session expiration

1 participant