[core] Replace proxy-based rewriter with DPSC approach #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ert rewrite to fix nesting issues
* fmt * fix
velzie
added a commit
that referenced
this pull request
Aug 29, 2025
* [core][rewriter] dpsc: partially implement WrapAccess * [core][rewriter] dpsc: implement WrapSet and remove WrapThis * [core][rewriter] dpsc: implement WrapGetComputed * [core][rewriter] dpsc: fix nested WrapGet s * [core][rewriter] dpsc: implement WrapSetComputed * [core][rewriter] dpsc: fix nested computed gets * [core][rewriter] dspc: change eval() from a replace rewrite to an insert rewrite to fix nesting issues * [core][rewriter] dpsc: nuke strictchecker * [core][rewriter] fix dpsc wrapget (#3) * fmt * fix * [core] add dpsc types to config * [core][rewriter] dpsc: fix bad rewrite with wrapcomputedgetleft * [core][rewriter] dpsc: switch from computed wraps to dynamic property wraps * [core] add dpsc globals * [core] NUKE GLOBALPROXY * [core] dpsc: proxy location for document.location too * [core][rewriter] dpsc: fix eval rewrite * [core][rewriter] dpsc: handle the comma operator correctly in wrapped properties * [core] dpsc: oops --------- Co-authored-by: Toshit Chawda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prior to this the js rewriter worked with a proxy based system,
window.locationgetting rewritten to$wrap(window).location. this replaces it with the more heavy handed but reliable approach of checking all property accesses, egwindow.location->window.__scramjet$locationorwindow["locat"+"ion"]->window[$scramjet$prop("locat"+"ion")]this is a significant change, ensure sites still work