fs/event: consolidate fs.written to fs.write #1392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
the "worker reload on file update" feature has been tested manually |
KernelDeimos
reviewed
Aug 8, 2025
Contributor
|
'fs.write.file' should be emitted after await entryOp.awaitDone() and also after await svc_fileCache.invalidate(node). This can be done using the TeePromise class with two instances in an asynchronous IIFE. |
XiaochenCui
force-pushed
the
fs/events-1391
branch
from
7e6fb08 to
23b4b8c
Compare
Contributor
Author
This has been solved, I'll test the feature manually with Rafflesia |
stash changes
XiaochenCui
force-pushed
the
fs/events-1391
branch
from
23b4b8c to
eaf5ae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1391
Workers need to be fully tested before merge.