Skip to content

puterfs decoupling continued #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 19, 2025
Merged

puterfs decoupling continued #1963

merged 3 commits into from
Nov 19, 2025
+148 −662

Conversation

@KernelDeimos
Copy link
Contributor

@KernelDeimos KernelDeimos commented Nov 13, 2025

No description provided.

@KernelDeimos KernelDeimos force-pushed the 25BD0-puterfs-decoupling-continued branch from 775d29a to 0e6df28 Compare November 13, 2025 23:44
@KernelDeimos KernelDeimos mentioned this pull request Nov 18, 2025
Merged
@KernelDeimos
dev(puterfs): move mkshortcut, make ll_rmdir...
e42bcc8 
...use readdir from the provider instead of calling
fast_get_direct_descendants directly on fsEntryService.

This change is prerequisite to removing FSEntryService from core.
@KernelDeimos
rm: remove DatabaseFSEntryService from core
51e82dd
@KernelDeimos
dev: decouple FSEntryFetcher by adding hasChild
fd543bc 
Adding the hasChild method of FSNodeContext as well as a corresponding
method to filesystem providers is prerequisite to moving
FSEntryFetcher's logic into the new puterfs extension.
@KernelDeimos KernelDeimos force-pushed the 25BD0-puterfs-decoupling-continued branch from 0e6df28 to fd543bc Compare November 18, 2025 23:09
@KernelDeimos KernelDeimos marked this pull request as ready for review November 18, 2025 23:09
@KernelDeimos
Copy link
Contributor Author

KernelDeimos commented Nov 19, 2025

As was the case with #1961, test failure was not reproducible outside the GitHub CI action.

┌─────────────────────────────────┬───────────┬────────┬────────┬───────┐
│ (index)                         │ settings  │ passed │ failed │ total │
├─────────────────────────────────┼───────────┼────────┼────────┼───────┤
│ auth                            │ 'puterfs' │ 1      │ 0      │ 1     │
│ Cartesian Test for /write       │ 'puterfs' │ 24     │ 0      │ 24    │
│ Cartesian Test for /move        │ 'puterfs' │ 48     │ 0      │ 48    │
│ Cartesian Test for /copy        │ 'puterfs' │ 144    │ 0      │ 144   │
│ write and read                  │ 'puterfs' │ 6      │ 0      │ 6     │
│ move                            │ 'puterfs' │ 4      │ 0      │ 4     │
│ stat                            │ 'puterfs' │ 157    │ 0      │ 157   │
│ readdir                         │ 'puterfs' │ 115    │ 0      │ 115   │
│ mkdir                           │ 'puterfs' │ 23     │ 0      │ 23    │
│ batch                           │ 'puterfs' │ 4      │ 0      │ 4     │
│ delete                          │ 'puterfs' │ 7      │ 0      │ 7     │
│ single write for trace and span │ 'puterfs' │ 0      │ 0      │ 0     │
└─────────────────────────────────┴───────────┴────────┴────────┴───────┘

@KernelDeimos KernelDeimos merged commit d3881f2 into main Nov 19, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@KernelDeimos