Skip to content

Move thumbnail mutation to getSafeEntry #1980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2025
+5 −5
Merged

Move thumbnail mutation to getSafeEntry #1980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/backend/src/filesystem/FSNodeContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ module.exports = class FSNodeContext {
* @void
*/
async fetchEntry (fetch_entry_options = {}) {
const svc_event = this.services.get('event');
if ( this.fetching !== null ) {
await Context.get('services').get('traceService').spanify('fetching', async () => {
// ???: does this need to be double-checked? I'm not actually sure...
Expand All @@ -309,9 +308,6 @@ module.exports = class FSNodeContext {
) {
const promise = this.fetching;
this.fetching = null;
if (this.entry.thumbnail) {
await svc_event.emit("thumbnail.read", this.entry);
}
promise.resolve();
return;
}
Expand Down Expand Up @@ -360,7 +356,6 @@ module.exports = class FSNodeContext {
const promise = this.fetching;
this.fetching = null;

await svc_event.emit("thumbnail.read", this.entry);
promise.resolve();
}

Expand Down Expand Up @@ -786,6 +781,8 @@ module.exports = class FSNodeContext {
}

async getSafeEntry(fetch_options = {}) {
const svc_event = this.services.get('event');

if ( this.found === false ) {
throw new Error(`Tried to get entry of non-existent fsentry: ` +
this.selector.describe(true));
Expand All @@ -794,6 +791,9 @@ module.exports = class FSNodeContext {

const res = this.entry;
const fsentry = {};
if (res.thumbnail) {
await svc_event.emit("thumbnail.read", this.entry);
}

// This property will not be serialized, but it can be checked
// by other code to verify that API calls do not send
Expand Down
Loading