Fix undefined variables and make it impossible to have them #1995
+418
−328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We might get rid of this later, or re-write it, so this isn't really a concern right now but this cleans up eslint error output.
It's about time to do this now. This file will for the first time (in... ever?) be indented with 4 spaces instead of 2.
This is an error in a handler for a failure case so it shouldn't be affecting users, but let's handle this error gracefully. This was a symbol that became not defined after moving PuterFSProvider to the extension.
I was having issues getting to a branch that calls a non-existing function so I wrote some comments about the issue here.
There's a potential issue here because of an undefined reference, but I can't seem to reproduce any problem caused by this. However without this fix this line of code is guarenteed to throw an exception so this fix should be safe.
This is the last error for the mandatory eslint rules. Now we can put a rule into place so that CI always fails when there's an undefined variable, which I think is pretty cool.
This commit adds verification for statically identifiable definite errors. Sometimes global variables used will be falsely reported as undefined variables in which case the new file `mandatory.eslint.config.js` should be updated to include these definitions in the narrowest scope possible that has these definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add
mandatory.eslint.config.jswhich contains mandatory eslint rules. These rules will be validated onnpm run buildso CI should fail if validation fails.This PR contains many small changes that are in separate commits, and I will be rebase-merging them so that calls for an explanation. These changes are very much unrelated to reach other (same kind of error mostly, but across different concerns), and if for any reason one of these changes causes a regression it will be much quicker to identify the issue using
git bisectthan by trying to analyze the changes and see what went wrong.