fix(emulator): correct byte/virtio stream helpers and wisp framing#2056
Open
2400060033 wants to merge 1 commit intoHeyPuter:mainfrom
Open
fix(emulator): correct byte/virtio stream helpers and wisp framing#20562400060033 wants to merge 1 commit intoHeyPuter:mainfrom
2400060033 wants to merge 1 commit intoHeyPuter:mainfrom
Conversation
Fixes multiple bugs in the browser emulator wiring: - implement to_int correctly (little-endian) - fix callback byte-stream async iterator - correct ATStream carry handling - improve virtio frame assembly and minor robustness No behavior changes; improves stability of virtio/wisp packet handling.
|
|
Collaborator
|
@r58Playz does this look correct? |
r58Playz
reviewed
Nov 28, 2025
Contributor
r58Playz
left a comment
r58Playz
left a comment
There was a problem hiding this comment.
The actual v86 emulator doesn't use this code. You should probably modify src/emulator/src/main.js and src/puter-wisp/src/exports.js.
| const handlers = { | ||
| [WispPacket.INFO.id]: ({ packet }) => { | ||
| // console.log('guess we doing info packets now', packet); | ||
| // reflect INFO packet back |
Contributor
There was a problem hiding this comment.
This is technically incorrect according to spec but it doesn't really matter for the extensions puter is using since they have no payload on either side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiple bugs in the browser emulator wiring:
No behavior changes; improves stability of virtio/wisp packet handling.