feat: add folder upload support to context menu#2081
Open
mohdanas86 wants to merge 2 commits intoHeyPuter:mainfrom
Open
feat: add folder upload support to context menu#2081mohdanas86 wants to merge 2 commits intoHeyPuter:mainfrom
mohdanas86 wants to merge 2 commits intoHeyPuter:mainfrom
Conversation
- Add 'Upload Folder Here' option to desktop and window context menus - Create new folder upload input with webkitdirectory attribute - Implement init_folder_upload_using_dialog handler function - Add translation string for 'upload_folder_here' Fixes UX inconsistency where drag-and-drop supports folders but right-click context menu only supported individual files.
|
|
Contributor
|
Hi there, Apologies for the delay. I'd love to review and potentially merge this PR; however, the formatting changes make it very difficult to perform a review. Could you take a look at changing the formatting modification back? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds "Upload Folder Here" option to context menus, fixing UX inconsistency where drag-and-drop supported folders but the right-click context menu only supported individual files.
Changes
webkitdirectoryattribute inUIDesktop.jsinit_folder_upload_using_dialog()handler function inhelpers.jsupload_folder_hereinen.jsTechnical Details
upload_items()function for consistencywebkitdirectoryattribute (supported in all modern browsers)Testing Performed
Screenshots
Related Issues
Closes #2080
Checklist