Skip to content

chore(deps): bump rio-vt from 0.5.25 to 0.5.26 - #5694

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/rio-vt-0.5.26
Closed

chore(deps): bump rio-vt from 0.5.25 to 0.5.26#5694
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/cargo/rio-vt-0.5.26

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 28, 2026

Copy link
Copy Markdown
Contributor

Bumps rio-vt from 0.5.25 to 0.5.26.

Release notes

Sourced from rio-vt's releases.

v0.5.26

Full Changelog: https://rioterm.com/changelog

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Aug 28, 2026
@dependabot
dependabot Bot requested a review from Hmbown as a code owner August 28, 2026 21:14
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Aug 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks @dependabot[bot] for taking the time to contribute.

This repository is observing a maintainer-managed PR intake gate in dry-run mode, so this pull request is staying open. This note helps maintainers prepare the allowlist before any enforcement is considered.

Please read CONTRIBUTING.md for the expected contribution shape. A maintainer can grant recurring PR access by commenting /lgtm on a pull request.

Bumps [rio-vt](https://github.com/raphamorim/rio) from 0.5.25 to 0.5.26.
- [Release notes](https://github.com/raphamorim/rio/releases)
- [Commits](raphamorim/rio@v0.5.25...v0.5.26)

---
updated-dependencies:
- dependency-name: rio-vt
  dependency-version: 0.5.26
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/cargo/rio-vt-0.5.26 branch from df53676 to 7a71d57 Compare August 29, 2026 03:15
@Hmbown

Hmbown commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Thanks @dependabot — this one needs a small source change alongside the lock bump, so leaving it open rather than rebasing.

All three reds (Lint, Test ubuntu-latest, Test macos-latest on run 33230921708) are the same compile error: error[E0616]: field 'style_set' of struct 'rio_vt::crosswords::grid::Grid' is private. rio-vt 0.5.26 made Grid.style_set private and added pub fn styles(&self) -> &[Style] (rio-vt/src/crosswords/grid/mod.rs:716 at tag v0.5.26; it was pub style_set at :74 in v0.5.25). The change is not called out in the release notes.

Exact fix, three lines in crates/tui/tests/support/qa_harness/frame.rs (:166, :173, :192):

-        let styles = self.term.grid.style_set.styles();
+        let styles = self.term.grid.styles();

Same &[Style] return type, so square_colors(square, styles) is unchanged, and nothing else in the tree references style_set. Note that frame.rs is compiled only under #[cfg(all(unix, feature = "long-running-tests"))] (crates/tui/tests/cucumber/plugin_e2e_acceptance.rs:18), so verify with cargo check -p codewhale-tui --tests --all-features on macOS or Linux — the Windows pass on this run is not evidence.

Plan: a maintainer branch carrying cargo update -p rio-vt --precise 0.5.26 plus that edit will supersede this PR; this will be closed with a link when that lands.

@Hmbown

Hmbown commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Maintainer fix branch for this bump is up: fix/rio-vt-0.5.26-qa-harness-20260830 @ e3cc1a45fa432423b26cb7a3235520f20072f422 (this PR's lock bump 7a71d57380 merged with main, plus the three-line frame.rs change from the receipt above — self.term.grid.style_set.styles()self.term.grid.styles() at :166, :173, :192).

Confirmed against the 0.5.26 crate source in the registry: Grid.style_set is private (src/crosswords/grid/mod.rs:83) and pub fn styles(&self) -> &[Style] is at :716; square_colors(square, styles) already takes &[Style], so nothing else changes.

Proof on macOS (the harness is compiled only under #[cfg(all(unix, feature = "long-running-tests"))], and it lives in the consolidated cucumber test target):

$ cargo test -p codewhale-tui --test cucumber --features long-running-tests --no-run
    Finished `test` profile [unoptimized + debuginfo] target(s) in 2m 53s
  Executable tests/cucumber/main.rs (target/debug/deps/cucumber-9cefaf79f65d85db)

$ cargo check -p codewhale-tui --all-targets
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 53s

$ cargo check -p codewhale-tui --tests --all-features
    Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 50s

Negative control with the fix stashed, same gated command: the same three error[E0616]: field style_setof structrio_vt::crosswords::grid::Grid is private at frame.rs:166:37, :173:37, :192:37 that CI reported, so the gate does exercise the file.

A maintainer will land this via the fix branch. Dependabot's branch cannot take a non-force push from us and we do not force-push, so this PR will be closed with a link once the branch merges.

Hmbown added a commit that referenced this pull request Aug 30, 2026
…60830

chore(deps): bump rio-vt to 0.5.26 with the qa_harness Grid API follow-up (lands dependabot #5694)
@Hmbown Hmbown closed this in #5741 Aug 30, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 30, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/cargo/rio-vt-0.5.26 branch August 30, 2026 20:02
yermakoffivan pushed a commit to yermakoffivan/CodeWhale that referenced this pull request Aug 30, 2026
rio-vt 0.5.26 made `Grid.style_set` private and added
`pub fn styles(&self) -> &[Style]` (rio-vt/src/crosswords/grid/mod.rs:716
at v0.5.26; `pub style_set` at :74 in v0.5.25). Update the three call
sites in the PTY QA harness so the `long-running-tests` gated `cucumber`
target compiles again on unix. Same `&[Style]` return type, so
`square_colors` is unchanged.

Supersedes Hmbown#5694 (dependabot lock bump, carried in this branch).

Verified:
  cargo test -p codewhale-tui --test cucumber --features long-running-tests --no-run
  cargo check -p codewhale-tui --all-targets
  cargo check -p codewhale-tui --tests --all-features

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014aDEyM2a4pPZ9qqMDrP5YX
Signed-off-by: CodeWhale Bot <bot@codewhale.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant