Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove workaround for coq/coq#8994 #1807

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Alizter
Copy link
Collaborator

@Alizter Alizter commented Jan 12, 2024

This changed the behaviour of resolution in a few places, but nothing a quick modification to the proof wouldn't fix.

@jdchristensen
Copy link
Collaborator

What about the other fields that still have primed versions?

@Alizter
Copy link
Collaborator Author

Alizter commented Jan 12, 2024

Actually that's a good point. I've only addressed one. I'll draft this for now and make sure I've got them all.

Well, specifically about that bug anyway. I need to think a bit more about why we still have primed fields in CatEquiv.

@Alizter Alizter marked this pull request as draft January 12, 2024 22:25
@jdchristensen
Copy link
Collaborator

(Just to be clear, I meant the other fields of the same Class.)

@Alizter
Copy link
Collaborator Author

Alizter commented Jan 12, 2024

I tried removing the primes in the other fields and got the wildcat library working, however Coq gets stuck on the Defined of one of the proofs of ExactSequence. Specifically isexact_connect_R.

Not sure what is going on there. I'll keep my changes and submit in a PR after this is merged if you want to take a closer look.

@jdchristensen
Copy link
Collaborator

I guess the issue is the one explained in a comment: Since apparently a field of a record can't be the source of a coercion ....

I think it's fine to merge this to at least get rid of one redefinition.

@Alizter
Copy link
Collaborator Author

Alizter commented Jan 12, 2024

I also had a go at removing InO_internal from ReflectiveSubuniverse but I was not successful.

@Alizter Alizter marked this pull request as ready for review January 12, 2024 23:45
@Alizter
Copy link
Collaborator Author

Alizter commented Feb 19, 2024

Rebasing this breaks DisplayedEquiv. @gio256 could you have a look at what is wrong? I wasn't able to fix it.

- fixes HoTT#1541

Signed-off-by: Ali Caglayan <[email protected]>
@Alizter Alizter force-pushed the ps/branch/remove_workaround_for_coq_coq_8994 branch from 5b53a31 to cc98084 Compare February 19, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove workarounds for coq/coq#8994
2 participants