chore: HoTT.Tests -> HoTT_Tests, HoTT.Contrib -> HoTT_Contrib #2342
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alizter
force-pushed
the
push-kmlxqqvozmpl
branch
from
fb0da96 to
c53a0db
Compare
This fixes issues HoTT#2313 and HoTT#2285 by avoiding ambiguous module paths like HoTT.Contrib.X which could conflict with HoTT.X. Signed-off-by: Ali Caglayan <[email protected]>
Alizter
force-pushed
the
push-kmlxqqvozmpl
branch
from
c53a0db to
6f9ed66
Compare
Collaborator
jdchristensen
left a comment
jdchristensen
left a comment
There was a problem hiding this comment.
This definitely makes sense for HoTT.tests, since we use the same paths there. I'm not sure about HoTT.Contrib, but it's fine with me to change that.
BTW, I've always found it odd that the folder is called test but the module is called Tests. Should we rename the folder to tests? (There's also the issue of the leading capital in the names Tests and Contrib; should the folders be capitalized as well?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issues #2313 and #2285 by avoiding ambiguous module paths like HoTT.Contrib.X which could conflict with HoTT.X.