DEV-563 Send Email and Logging Logic#69
Merged
Spencer04Hire merged 2 commits intopreviewfrom Feb 5, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
backend/hoagiemail/api/mail_view.py
Outdated
| @@ -203,7 +210,6 @@ def handle_scheduled_email(mail_data, user): | |||
| if settings.DEBUG: | |||
Contributor
There was a problem hiding this comment.
Do this still need to check settings.DEBUG or is it like before where the logs only show up when DEBUG=True?
Contributor
Author
There was a problem hiding this comment.
not for the logs but the message doesn't need to be created unless we're printing the email
backend/.env.example
Outdated
| @@ -1,11 +1,17 @@ | |||
| DEBUG=True | |||
| SECRET_KEY= | |||
| DEBUG="True" # Print debug logs | |||
Contributor
There was a problem hiding this comment.
Add a bit more detail for these comments and put them on their own line. It should be super clear what each env var does so no one mixes them up
Spencer04Hire
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes