style(hf-icons): Use Hf Icon Library #514
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to integrate the Hf Icon Library by removing the existing IconLinkComponent and updating its usage.
- Removed the IconLinkComponent file.
- Updated the AHB table component to eliminate the IconLinkComponent reference.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/shared/components/icon-link/icon-link.component.ts | Removed the icon link component in favor of using the new Hf Icon Library. |
| src/app/features/ahbs/components/ahb-table/ahb-table.component.ts | Removed the IconLinkComponent import as part of the updated icon integration. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the AHB table component to use the new Hf Icon Library by removing the redundant IconLinkComponent.
- Removed IconLinkComponent import from the AHB table component.
- Deleted the IconLinkComponent file from the shared components directory.
Reviewed Changes
Copilot reviewed 4 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/app/features/ahbs/components/ahb-table/ahb-table.component.ts | Removed IconLinkComponent usage to integrate the new Hf Icon Library. |
| src/app/shared/components/icon-link/icon-link.component.ts | Deleted the redundant IconLinkComponent. |
Files not reviewed (9)
- package.json: Language not supported
- src/app/features/ahbs/components/ahb-table/ahb-table.component.html: Language not supported
- src/app/features/ahbs/views/ahb-landing-page/ahb-landing-page.component.html: Language not supported
- src/app/features/landingpage/views/landing-page/landing-page.component.html: Language not supported
- src/app/shared/components/footer/footer.component.html: Language not supported
- src/app/shared/components/icon-link/icon-link.component.html: Language not supported
- src/app/shared/components/login-button/login-button.component.html: Language not supported
- src/assets/companystylesheet: Language not supported
- src/styles.scss: Language not supported
Comments suppressed due to low confidence (1)
src/app/features/ahbs/components/ahb-table/ahb-table.component.ts:24
- The Angular component decorator property should likely be 'styleUrls' (an array) instead of 'styleUrl'.
styleUrl: './ahb-table.component.scss',
|
I guess we can remove all the icon components if we use the new icon library |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.