feat: Add validation, that IdentificationDateTime is German midnight
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request adds a custom validation attribute to ensure that a DateTimeOffset value is at German midnight and updates tests and model documentation accordingly.
- Introduces the GermanMidnightValidationAttribute to verify that the provided DateTimeOffset corresponds to midnight in German local time.
- Adds tests to validate the serialization of the German timezone and the correct behavior of the validation attribute.
- Updates the IdentificationParameter model by applying the new validation attribute and adding related documentation.
Reviewed Changes
| File | Description |
|---|---|
| MaLoIdentModels/MaLoIdentModels/Validation/GermanMidnightValidationAttribute.cs | Implements a new attribute for validating German midnight. |
| MaLoIdentModels/MaLoIdentModelsTests/v1Tests/SerializeGermanTimezoneInfo.cs | Tests the serialization and deserialization of the German timezone information. |
| MaLoIdentModels/MaLoIdentModelsTests/v1Tests/DateTimeOffsetDeserializationTests.cs | Adds theory tests to check validation of German midnight times. |
| MaLoIdentModels/MaLoIdentModels/v1/IdentificationParameter.cs | Applies the new validation attribute and updates documentation for clarity. |
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
MaLoIdentModels/MaLoIdentModels/v1/IdentificationParameter.cs:14
- [nitpick] The XML summary for IdentificationParameter is empty; please add a meaningful description that clarifies the purpose of this property.
/// <summary>
MaLoIdentModels/MaLoIdentModels/Validation/GermanMidnightValidationAttribute.cs
Outdated
Show resolved
Hide resolved
JoschaMetze
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.