feat: normalize/sanitize Anwendungsfall.beschreibung
#176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hf-kklein
pushed a commit
that referenced
this pull request
Sep 22, 2025
based on #176 (no depedency - just to avoid merge conflicts)
hf-kklein
added a commit
that referenced
this pull request
Oct 1, 2025
…et) (#177) * feat: introduce function to parse `Kommunikation_von` (w/o using it yet) based on #176 (no depedency - just to avoid merge conflicts) * fix some more edge cases --------- Co-authored-by: Konstantin <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to normalize and sanitize the Anwendungsfall.beschreibung field by removing line breaks and hyphens according to specific rules.
- Implements a new utility function
remove_linebreaks_and_hyphensthat handles whitespace normalization and hyphen removal - Adds comprehensive unit tests covering various edge cases including trailing whitespace, line breaks, and hyphen-linebreak combinations
- Updates the AHB reader to use the new normalization function for the
beschreibungattribute
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/fundamend/utils.py | Adds the new normalization function with replacement rules and exports it |
| unittests/test_utils.py | Provides comprehensive test coverage for the normalization function |
| src/fundamend/reader/ahbreader.py | Integrates the new normalization function into the Anwendungsfall creation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hf-krechan
reviewed
Oct 15, 2025
Comment on lines
6
to
48
| def lstrip(prefix: str, text: str) -> str: | ||
| """Strip the given prefix from the given text. If the text does not start with the prefix, return the text as is. | ||
| Args: | ||
| prefix: The prefix to strip. | ||
| text: The text to strip the prefix from. | ||
| Returns: | ||
| The text with the prefix stripped. | ||
| """ | ||
| if text.startswith(prefix): | ||
| return text[len(prefix) :] | ||
| return text | ||
|
|
||
|
|
||
| def rstrip(text: str, suffix: str) -> str: | ||
| """Strip the given suffix from the given text. If the text does not end with the suffix, return the text as is. | ||
| Args: | ||
| text: The text to strip the suffix from. | ||
| suffix: The suffix to strip. | ||
| Returns: | ||
| The text with the suffix stripped. | ||
| """ | ||
| if text.endswith(suffix): | ||
| return text[: -len(suffix)] | ||
| return text | ||
|
|
||
|
|
||
| def strip(prefix: str, text: str, suffix: str) -> str: | ||
| """Strip the given prefix and suffix from the given text. If the text does not start with the prefix or does not | ||
| end with the suffix, return the text as is. | ||
| Args: | ||
| prefix: The prefix to strip. | ||
| text: The text to strip the prefix from. | ||
| suffix: The suffix to strip. | ||
| Returns: | ||
| The text with the prefix and suffix stripped. | ||
| """ | ||
| return lstrip(prefix, rstrip(text, suffix)) |
There was a problem hiding this comment.
wieso erfinden wir die strip methoden nochmal neu?
https://docs.python.org/3/library/stdtypes.html#str.lstrip
hf-krechan
approved these changes
Oct 15, 2025
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #172