Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Code documentation #71

Merged
merged 5 commits into from
Jan 20, 2025
Merged

Improve Code documentation #71

merged 5 commits into from
Jan 20, 2025

Conversation

FreddyFox892
Copy link
Contributor

No description provided.

@FreddyFox892 FreddyFox892 changed the title Improve Doku Improve Code documentation Jan 15, 2025
@hf-kklein hf-kklein marked this pull request as ready for review January 15, 2025 15:32
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bitte sei noch so gut und vereinheitliche die Beispiele. Du verwendest 3 verschiende Quotes wild gemischt für die Viertel-Tags:

´<C_xxxx´

mit zwei Forward Ticks

"<AWF"

mit zwei double quotes

`<AHB´

mit back tick und forward tick.

Ich wäre für konsistent nur backticks.

Zugegeben war das bei den deutschen Begriffen vorher auch schon ein Mix aus single und double quotes. Aber wenn wir eh drüber gehen, dann doch am besten gleich einheitlich alles machen.

Comment on lines 96 to 97
A "Segmentgruppe" inside an AHB, indicated by the ´<G_xxxx´ tag.
This model can contain both Segments and segment groups.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ist das nicht sogar: G_SG?
zumindest für UTILTS und UTILMD ist das so:

return element.tag.startswith("G_SG")

oder es klappt nur zufällig ;)

Comment on lines +54 to +55
status_std: MigStatus # e.g. M
status_specification: MigStatus # e.g. M
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hier hätte der mehrwert imho eher darin gelegen, das man die einzelne enum Members von MigStatus dokumentiert statt hier den ersten member als beispiel zu ergänzen.

@hf-kklein hf-kklein enabled auto-merge (squash) January 20, 2025 09:36
@hf-kklein hf-kklein linked an issue Jan 20, 2025 that may be closed by this pull request
16 tasks
@hf-kklein hf-kklein merged commit 20f1f75 into main Jan 20, 2025
24 checks passed
@hf-kklein hf-kklein deleted the FST/docuAddOn branch January 20, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper documentation to the different model classes
4 participants