Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(model): Use pydantic always and explicitly #75

Merged
merged 4 commits into from
Jan 22, 2025
Merged

refactor(model): Use pydantic always and explicitly #75

merged 4 commits into from
Jan 22, 2025

Conversation

lord-haffi
Copy link
Collaborator

No description provided.

@lord-haffi lord-haffi self-assigned this Jan 20, 2025
@hf-kklein
Copy link
Contributor

hf-kklein commented Jan 20, 2025 •
edited
Loading

reads like trying to be smart wasn't what you as a user expected from the library :P

hf-kklein
hf-kklein approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@hf-kklein hf-kklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entfernst du noch die optionale dependency pydantic und ´passt die readme an, dass man nicht mehr fundamend[pydantic] installieren kann?

@DeltaDaniel DeltaDaniel requested a review from hf-kklein January 22, 2025 09:01
@hf-kklein
Copy link
Contributor

und jetzt bitte noch die CI umbauen:

xml-fundamend-python/.github/workflows/unittests.yml

Line 13 in ee6d5e6

pydantic: [install_pydantic, skip_pydantic]

den schritt brauchen wir ja nicht mehr.

@hf-kklein
Copy link
Contributor

ich fixe die branch protection. moment...

@hf-kklein hf-kklein merged commit de261cf into main Jan 22, 2025
18 checks passed
@hf-kklein hf-kklein deleted the pydantify branch January 22, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf-kklein hf-kklein hf-kklein approved these changes

@DeltaDaniel DeltaDaniel DeltaDaniel approved these changes

Assignees

@lord-haffi lord-haffi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lord-haffi @hf-kklein @DeltaDaniel