Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ahb_status field to DataElement class #83

Merged
merged 4 commits into from
Jan 30, 2025

Conversation

alex2702
Copy link
Contributor

This PR adds the ahb_status field (currently part of the SegmentGroup, Segment, and Code classes) to the DataElement class and extends the AHB reader to fill in the field when creating DataElement instances.

@hf-kklein
Copy link
Contributor

hf-kklein commented Jan 30, 2025

@alex2702 thanks for your contribution!

just ping me here, if you need any help with the PR. The tests in the CI run on the actual BDEW data which are loaded from a private submodule (we cannot publish them because they are from a paid BDEW subscription). Because you are not a member of the Hochfrequenz organization on Github, you cannot checkout this submodule, so some tests will probably fail on your localhost.

anyway: tox -e snapshots should work for the files that once were publicly available on the bdew website and are still checked in here: https://github.com/Hochfrequenz/xml-fundamend-python/blob/main/unittests/example_files/UTILTS_AHB_1.1d_Konsultationsfassung_2024_04_02.xml

@hf-kklein hf-kklein changed the title Add ahb_status field to DataElement class feat: Add ahb_status field to DataElement class Jan 30, 2025
@hf-kklein hf-kklein marked this pull request as ready for review January 30, 2025 16:04
@hf-kklein hf-kklein merged commit 9a50ada into Hochfrequenz:main Jan 30, 2025
11 of 18 checks passed
@hf-kklein
Copy link
Contributor

@alex2702 Your code was was actually just missing the snapshots. I updated them in cbcb614 and merged it :)

Thanks again. Your code is part of any version >=v0.10.0

@alex2702
Copy link
Contributor Author

Thanks a lot for getting this merged and released so quickly @hf-kklein!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants