Skip to content

Conversation

@mainred
Copy link
Collaborator

@mainred mainred commented Dec 29, 2025

It makes less code change if we get the packages import sequence aligned by isort. Isort has been used separated or integrated with IDE to sort the python import packages to make the package import clean and tidy.
I explicitly excluded sever.py, experimental/ag-ui/server-agui.py and holmes/main.py from isort check which has extra requirement for the package import sequence out of custom certification consideration.

Isort has gone through all python files in this repo, and updated the files that requires package import sequence adjustment in this PR, so please expect a large number of file change.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 29, 2025

Important

Review skipped

Too many files!

118 files out of 268 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mainred
Copy link
Collaborator Author

mainred commented Dec 29, 2025

I expect this change collaborate with precommit github action check to protect the package import sequence, but somehow we removed the action by #1154. @moshemorad to provide the reason.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 29, 2025

Docker image ready for 64a89d2 (built in 5m 19s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:64a89d2
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/holmes:64a89d2 me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:64a89d2
docker push me-west1-docker.pkg.dev/robusta-development/development/holmes-dev:64a89d2

Patch Helm values in one line (choose the chart you use):

HolmesGPT chart:

helm upgrade --install holmesgpt ./helm/holmes \
  --set registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set image=holmes-dev:64a89d2

Robusta wrapper chart:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set holmes.registry=me-west1-docker.pkg.dev/robusta-development/development \
  --set holmes.image=holmes-dev:64a89d2

@mainred mainred requested a review from moshemorad December 29, 2025 07:57
@github-actions
Copy link
Contributor

Results of HolmesGPT evals

  • ask_holmes: 7/7 test cases were successful, 0 regressions
Test suite Test case Status
ask 09_crashpod
ask 101_loki_historical_logs_pod_deleted
ask 12_job_crashing
ask 162_get_runbooks
ask 176_network_policy_blocking_traffic_no_runbooks
ask 43_current_datetime_from_prompt
ask 61_exact_match_counting

Legend

  • ✅ the test was successful
  • :minus: the test was skipped
  • ⚠️ the test failed but is known to be flaky or known to fail
  • 🚧 the test had a setup failure (not a code regression)
  • 🔧 the test failed due to mock data issues (not a code regression)
  • 🚫 the test was throttled by API rate limits/overload
  • ❌ the test failed and should be fixed before merging the PR

arikalon1
arikalon1 previously approved these changes Jan 1, 2026
@mainred mainred force-pushed the mainred/add-isort-precommit-check branch from a1bbbb8 to 0c04977 Compare January 2, 2026 00:28
@mainred
Copy link
Collaborator Author

mainred commented Jan 2, 2026

@arikalon1 Thanks for your review. This PR involves too many files and easily have conflicts. Please help merge this PR if it's ready before we have other new changes. Thanks.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2026

✅ Results of HolmesGPT evals

Automatically triggered by commit 0c04977 on branch mainred/add-isort-precommit-check

View workflow logs

Results of HolmesGPT evals

  • ask_holmes: 9/9 test cases were successful, 0 regressions
Status Test case Time Turns Tools Cost
09_crashpod 29.9s ↓13% 5 11 $0.1490
101_loki_historical_logs_pod_deleted 64.7s ↑21% 10 18 $0.2355
111_pod_names_contain_service 46.8s ↑17% 8 16 $0.1925
12_job_crashing 49.1s ±0% 8 18 $0.2060
162_get_runbooks 55.2s ↑11% 8 19 $0.2418
176_network_policy_blocking_traffic_no_runbooks 46.3s ↑23% 7 14 $0.1894
24_misconfigured_pvc 39.1s ±0% 7 13 $0.1579
43_current_datetime_from_prompt 3.7s ±0% 1 $0.0621
61_exact_match_counting 10.8s ±0% 3 3 $0.0860
Total 38.4s avg 6.3 avg 14.0 avg $1.5203

Time/Cost columns show % change vs historical average (↑slower/costlier, ↓faster/cheaper). Changes under 10% shown as ±0%.

Historical Comparison Details

Filter: excluding branch 'mainred/add-isort-precommit-check'

Status: Success - 18 test/model combinations loaded

Experiments compared (30):

Comparison indicators:

  • ±0% — diff under 10% (within noise threshold)
  • ↑N%/↓N% — diff 10-25%
  • ↑N%/↓N% — diff over 25% (significant)
📖 Legend
Icon Meaning
The test was successful
The test was skipped
⚠️ The test failed but is known to be flaky or known to fail
🚧 The test had a setup failure (not a code regression)
🔧 The test failed due to mock data issues (not a code regression)
🚫 The test was throttled by API rate limits/overload
The test failed and should be fixed before merging the PR
🔄 Re-run evals manually

⚠️ Warning: /eval comments always run using the workflow from master, not from this PR branch. If you modified the GitHub Action (e.g., added secrets or env vars), those changes won't take effect.

To test workflow changes, use the GitHub CLI or Actions UI instead:

gh workflow run eval-regression.yaml --repo HolmesGPT/holmesgpt --ref mainred/add-isort-precommit-check -f markers=regression

Option 1: Comment on this PR with /eval:

/eval
markers: regression

Or with more options (one per line):

/eval
model: gpt-4o
markers: regression
filter: 09_crashpod
iterations: 5

Run evals on a different branch (e.g., master) for comparison:

/eval
branch: master
markers: regression
Option Description
model Model(s) to test (default: same as automatic runs)
markers Pytest markers (no default - runs all tests!)
filter Pytest -k filter (use /list to see valid eval names)
iterations Number of runs, max 10
branch Run evals on a different branch (for cross-branch comparison)

Quick re-run: Use /last to re-run the most recent /eval on this PR with the same parameters.

Option 2: Trigger via GitHub Actions UI → "Run workflow"

🏷️ Valid markers

benchmark, chain-of-causation, compaction, context_window, coralogix, counting, database, datadog, datetime, easy, embeds, grafana-dashboard, hard, kafka, kubernetes, leaked-information, logs, loki, medium, metrics, network, newrelic, no-cicd, numerical, one-test, port-forward, prometheus, question-answer, regression, runbooks, slackbot, storage, toolset-limitation, traces, transparency


Commands: /eval · /last · /list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants