Feature: Collabs tab on Home and Favorites page#727
Open
INCENDE wants to merge 7 commits intoHolodexNet:devfrom
Open
Feature: Collabs tab on Home and Favorites page#727INCENDE wants to merge 7 commits intoHolodexNet:devfrom
INCENDE wants to merge 7 commits intoHolodexNet:devfrom
Conversation
- extract out status, type, and include to a constant map - remove home live/upcoming tab from map since it is handled by another module
- enclose shared query inside async return - move shared variable "res" outside if/else scope to allow change in next commit
INCENDE
force-pushed
the
feature/collab-tab-on-home-favourites-page
branch
from
810ddf2 to
db45490
Compare
sphinxrave
approved these changes
Sep 23, 2023
Collaborator
sphinxrave
left a comment
sphinxrave
left a comment
There was a problem hiding this comment.
this looks interesting, and doesn't seem like it breaks any existing features, good work. The idea to organize it into a query map is also pretty neat.
Collaborator
|
I'll wait for ricecakes to make a executive decision here since it has high UI impact |
Member
|
This looks like a fun addition, but I'm not sure if an entire tab fits the structure (i.e. Upcoming Streams, VODs and Clips are separate entities, while a Collab is not.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #579
Features
Add Collabs tab to home and favorites pages
mentionsConnectedVideoListFuture work
It might be more efficient to process the request from the backend.